Giter Site home page Giter Site logo

Comments (5)

jomkz avatar jomkz commented on June 3, 2024 1

That seems reasonable to me. So the work required for this would be to simply output a message in the log if the secret is present. Does anyone have any problem with that?

from operator-certification-operator.

acornett21 avatar acornett21 commented on June 3, 2024

Key to be used in CR should be docker-registry when creating the secrete, since this is the value the pipeline uses.

from operator-certification-operator.

dcurran90 avatar dcurran90 commented on June 3, 2024

/assign

from operator-certification-operator.

dcurran90 avatar dcurran90 commented on June 3, 2024

This appears to already work as long as the user creates the registry-dockerconfig-secret and runs the following command:
tkn pipeline start operator-ci-pipeline \ --param git_repo_url=$GIT_REPO_URL \ --param git_branch=main \ --param bundle_path=$BUNDLE_PATH \ --param env=prod \ --param pin_digests=true \ --param git_username=$GIT_USERNAME \ --param git_email=$GIT_EMAIL \ --param registry=$REGISTRY \ --param image_namespace=$IMAGE_NAMESPACE \ --workspace name=pipeline,volumeClaimTemplateFile=templates/workspace-template.yml \ --workspace name=kubeconfig,secret=kubeconfig \ --workspace name=ssh-dir,secret=github-ssh-credentials \ --workspace name=registry-credentials,secret=registry-dockerconfig-secret \ --showlog

we can check if the secret exists and log this in the operator but since we aren't creating secrets in the operator itself there isn't a lot for the operator to do

from operator-certification-operator.

dcurran90 avatar dcurran90 commented on June 3, 2024

I'll open that PR right now so folks can see it.

from operator-certification-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.