RFE Add ability to handle multiple changes

[redhat-openstack]

RFE Add ability to handle multiple changes

[adarazs]

Looks like we need to handle 3 types of testing

• manual (we can ask the user to provide a list)
• Zuul based (ZUUL_HOST + ZUUL_CHANGES variable contains all required changes already)
• Jenkins (GERRIT_* variables and Depends-On in the commit message)

I think we can autodetect the type by looking for the specific env variables.

The manual mode seems simple, I imagine we could have something like this:

artg_change_list:
    - host: ...
      project: ...
      branch: ...
      refspec: ...
    - ...

The rest of the modes could parse the changes into the same format.

Parsing the ZUUL_CHANGES looks simple, it has this format: ZUUL_CHANGES="project1:branch1:refspec1^project2:branch2:refspec2:^..."

Parsing Depends-On is more involved, but we already have a fairly similar functionality implemented in khaleesi, so we could start out from that and return the result as a list of dictionaries.

[trown]

I like this approach. I think we would be able to integrate #1 into this quite easily by adding an extra task that has a when: item.packaging_host is defined, and then for packaging changes we would just add on to the artg_change_list like:

artg_change_list:
  - host: ...
    project: ...
    branch: ...
    refspec: ...
    packaging_host: ...
    packaging_branch: ...
    packaging_refspec: ...
  - ...

We could make code changes optional by making the git clone task for code chages have a when: item.host is defined as well, but this is not a requirement. I have been just setting the refspec to the branch (ie "master") to get the same behavior.

[adarazs]

Looks quite simple, I like the solution. I'll make WIP change without the packaging part first and add this functionality when that works.

[adarazs]

Added the basic functionality with a statically defined change list: https://review.gerrithub.io/277358

[adarazs]

Added Zuul change parsing to the review. Tested locally with a manually crafted ZUUL_CHANGES variable, it seemed to work fine.

[adarazs]

The change is feature complete (though it fails with certain packages like puppet-tripleo, because it doesn't have that hacked out install part from DLRN).

I tested all three methods manually (by adding env vars) and it worked even in complex dependency situations (with Jenkins), though I didn't test it with dependencies on different Gerrit servers.

[adarazs]

After converting the dependency resolvers to Ansible modules, and adding the "multiple changes with the same Change-Id" improvement, this should be really ready. Please review.

[adarazs]

The functionality merged: https://review.gerrithub.io/277358