Comments (4)
I thought it might be a good indicator if the commit is also present in Fedora.
Just checking a presence of a commit is not enough. One would have to check if the commit is on some systemd-stable
's release branch. But that doesn't work for cherry-picked commits, because their SHA is different, hence it's not very reliable indicator.
One of the solutions could be to drop
systemd/systemd-stable
from.github/.advanced-commit-linter.yml
.
Yeah, that sounds good to me.
from advanced-commit-linter.
I thought it might be a good indicator if the commit is also present in Fedora. But you are right that showing both links isn't useful most of the time since almost always commit is already in stable repo anyway.
One of the solutions could be to drop systemd/systemd-stable
from .github/.advanced-commit-linter.yml
. Or I can show only one link (essentially hardcoding it to actions code) or hide it behind a switch.
@dtardon What would you prefer?
from advanced-commit-linter.
One of the solutions could be to drop
systemd/systemd-stable
from.github/.advanced-commit-linter.yml
.Yeah, that sounds good to me.
Ok, I will submit PRs. Thanks for reporting this issue.
from advanced-commit-linter.
I have created PRs. I will close this issue. Feel free to reopen it if needed.
from advanced-commit-linter.
Related Issues (10)
- Add state of linked tracker to the issue comment
- Dependency Dashboard
- Show commits with missing tracker is section with commits that needs inspection
- Summary comment overhauled, use tables instead plain text :bookmark_tabs:
- Add labeler as replacement for Mergify :label:
- When initial PR comment is edited, then summary comment id is not detected and new comment is created HOT 1
- Use proper Check run instead of Commit status :statue_of_liberty:
- Make sure that all usecases works as expected :rescue_worker_helmet:
- Use `actions/labeler` to label PRs based on changed files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from advanced-commit-linter.