Comments (4)
from redis-rs.
@nihohit I'm working on a local trait to get the ones I need implemented so I can get a PR together.
A few questions
- should the options classes like StreamClaimOptions be
#[non_exhaustive]
(or not necessary since the internals are private). As I'll need to extend some of the like the StreamClaimOptions - can I create _options versions of some of these to make more concise variant? (e.g. xadd_options)
from redis-rs.
StreamClaimOptions
has only private fields, so I'm not sure how marking it asnon_exhaustive
would affect its behavior. AFAIK this attribute is only relevant for structs with (exclusively?) public fields.- sure, and since the fields are private, you can have the more verbose versions take the more concise versions as fields without breaking backwards compatibility.
from redis-rs.
also, I'll save you time on common comments we give to PRs -
- please open separate PRs for each command, or at least for each set of commands. If you'll open 1 huge PR, I'll ask to break it down.
- please add comprehensive sync & async tests for each command.
Thanks for the will to contribute :)
from redis-rs.
Related Issues (20)
- Things to complete for 0.26v HOT 3
- ConnectionManager with broken pipe HOT 2
- Issue with a simple GET command HOT 3
- Warning about Rust 2024 with the newest Nightly Compiler: `this function depends on never type fallback being ()` HOT 18
- [Redis Cluster] How scan by every nodes HOT 3
- is there a reason test_block_on_all_panics_from_spawns test is not marked as #[should_panic]? HOT 2
- Blocking operations and aio MultiplexedConnection HOT 14
- Master with given name not found in sentinel- MasterNameNotFoundBySentinel HOT 6
- Connection Timeout leads to data corruption HOT 1
- My Redis server enabled kerber verification, Can I use this client for it? HOT 1
- Support `query_async` for `ClusterPipeline` HOT 5
- Using redis with rustls is blocking HOT 2
- Alternatives to aio::Connection in combination with WATCH HOT 1
- How to dynamically reconstruct a Redis client based on cluster information? HOT 3
- EVALSHA in cluster pipelines HOT 1
- bug: Compilation error when compiling `sentinel` feature without `aio` feature, due to a configured-out struct being used.
- Things for version 0.27
- The remote host forcibly closed an existing connection. (os error 10054) HOT 5
- When building a ClusterClient using urls, the url param protocol=resp3 has no effect. HOT 1
- `tokio::sync::broadcast` support in async connection push senders HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redis-rs.