Connection not usable after parsing error. "broken pipe" when connection manager is used.

[tsmt-iris]

Connection not usable after parsing error. "broken pipe" when connection manager is used.

[tsmt-iris]

Here's also a log from our larger system where its difficult to share the code, but you can see what happens. First you get the parser error from the atomic pipeline including timeseries, then you have a broken pipe when r2d2 tries to reuse the connection in a different thread.

  2023-11-08T14:51:36.105726Z  WARN nucleus::datastore::redis::ts: Problem in timeseries: parse error - ResponseError: Parse error at 34
expected 3 more elements
    at lib/nucleus/src/datastore/redis/ts.rs:90 on main-workers ThreadId(27)

  2023-11-08T14:51:36.105930Z ERROR r2d2: broken pipe
    at /Users/ts/.cargo/registry/src/index.crates.io-6f17d22bba15001f/r2d2-0.8.10/src/lib.rs:121 on main-workers ThreadId(5)

[nihohit]

Hi @tsmt-iris,
AFAIS parsing errors will always mean that the connection is unusable - the stream from the server contains garbage, and so the parser cannot know when the garbage message ends and where does the next, hopefully correct, message begins. Do you know whether the message from the server actually is malformed, and if so - why? Can this be reproduced with local tests?

Additionally, the issue seems to be at least partially that the connection pool reuses faulty connections. Might this be an issue for the r2d2 crate?