No menu shortcut + console error message

[redmunds]

No menu shortcut + console error message

[redmunds]

I see the shortcut listed on my English Win7 system. The shortcuts are passed to brackets-shell to register in the native code, so it's probably because it's not valid with a german keyboard.

[marcelgerber]

Hm, I tried to find the error codes of brackets.app.setMenuItemShortcut, but I haven't found them (and yes, I searched for them in brackets-shell). Does anybody know them?

[redmunds]

brackets.app.setMenuItemShortcut calls the platform-specific implementation of SetMenuItemShortcut

On Windows, look in appshell/appshell_extensions_win.cpp:
Take a look at UpdateAcceleratorTable(). It only return true/false and most of the logic is in there -- mostly to do with virtual key mappings and unicode characters.

On Mac, look in appshell/appshell_extensions_mac.mm:
It does not seem to return an error for any shortcut.

[marcelgerber]

Hm, seems the comment on line 1297 explains why it doesn't work. But it's weird too because the shortcuts "Toggle Line Comment" and "Toggle Block Comment", which also use / as base key, are shown correctly (and there is no console output for them). Are they registered on another way?

[redmunds]

Most builtin shortcuts are defined using the base-config/keyboard.json file. I thought that they would use same underlying code path, but may not. Or maybe they are, but the console messages are suppressed.

[marcelgerber]

Yes, it seems they are handled on another way (_handleCommandRegistered in src/command/KeyBindingManager.js registers the shortcut for them, addMenuItem is called with only one param).

[redmunds]

@SAplayer I just noticed this issue is still open. Were you waiting on me for something?

[marcelgerber]

No, I just forgot to close it.
Closing.