Cannot install APKiD

[rednaga]

Cannot install APKiD

[strazzere]

Thanks Cryptax, I'm taking a look at this now. Pretty sure I know the issue and can fix it relatively fast.

Very nice and detailed bug report by the way 👍

[strazzere]

Ok as of;
rednaga/yara-python@88877e3

Both the yara-python module and the yara module should updated with a fix that will correct the compilation errors you are having.

[strazzere]

Per the comment on instructions being unclear, I think I understand what you're saying now. So for the "installing" instructions, we're simply trying to clarify that to use APKiD currently you must install our modified yara-python project. This, hopefully, is only until the project is merged upstream into the master yara-python project. This is why we have you cloning only yara-python and not APKiD, followed by using pip to install our package.

Does this make sense? I'm going to try and reword the README to clarify this.

[strazzere]

With commit;
9d7697b
I believe I've address some clarity issues, let us know if there are any issues now. 👍

[cryptax]

Hi Tim,

I had forgotten rednaga would go to you ;) Nice to "see" you again!

I'm afraid, I'm still having issues with compilation of yara-python. To be certain, I pulled a fresh repository for yara-python and apkid.

yara/libyara/modules/dex.c: In function ‘load_proto_ids’:
yara/libyara/modules/dex.c:429:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
   for (int i = 0, p = 0; p < proto_ids_size; i += 1, p += sizeof(PROTO_ID_ITEM)) {
   ^
yara/libyara/modules/dex.c:429:3: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
yara/libyara/modules/dex.c: In function ‘load_method_ids’:
yara/libyara/modules/dex.c:486:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
   for (int i = 0, p = 0; p < method_ids_size; i += 1, p += sizeof(METHOD_ID_ITEM)) {
   ^
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

I patched dex.c, with the following and then it compiled:

int i, p;
for (i = 0, p = 0; p < proto_ids_size; i += 1, p += sizeof(PROTO_ID_ITEM)) {

It's strange because your modification in rednaga/yara@6541005 has the fix. But look here, the fix is not in. I haven't investigated why.

[rojaster]

Hi @cryptax , I've got the same error message. Looks like two lines 429 and 486 were not modified.
But with clang3.7.1 I built successfully and with GCC I caught this bug.

[cryptax]

yep, @rojaster I saw your bug report :)