Giter Site home page Giter Site logo

Comments (5)

tatomyr avatar tatomyr commented on May 27, 2024 1

Hi @HenryGessau, there is yet another option to solve your case. While you can still use the recommended ruleset as your base, you can turn the severity of that specific rule to off and write your own configurable rule like this:

extends: 
  - recommended
rules:
  operation-2xx-response: off
  rule/operation-1xx-or-2xx-response:
    subject: 
      type: Responses
    assertions: 
      requireAny: 
        - '101'
        - '200'
        - ...

And then add as many required response codes as you need (probably all 2xxs and maybe even the default one). See more about configurable rules here.
This will ensure that every operation will have to contain at least one of the enlisted response codes.

from redocly-cli.

lornajane avatar lornajane commented on May 27, 2024

Thanks for the question! The recommended ruleset is aimed at being a solid recommendation for people with a basic API and little knowledge about APIs, to get them started in their API governance journey. Once up and running, almost all organisations should adjust the ruleset to fit their context, and I think that's the best approach here.

I'll close the issue since there's no action planned on our side, but please stay in touch if you have more comments or questions for us.

from redocly-cli.

meem avatar meem commented on May 27, 2024

@lornajane Understood on the goals of the recommended ruleset, but to be clear: we consider the operation-2xx-response rule generally quite valuable - e.g., we have hundreds of operations in our API and only a couple that make use of 101. Is there a way for us to off the check for a specific method (similar to being able to specify JSON pointers with Spectral rule overrides? That would enable us to keep the rule on in general while keeping the recommended ruleset simple.

from redocly-cli.

lornajane avatar lornajane commented on May 27, 2024

Yes there is! You can set an ignore for just the specific things you want to avoid having reported. The docs you want are over here: https://redocly.com/docs/cli/commands/lint/#generate-ignore-file

from redocly-cli.

HenryGessau avatar HenryGessau commented on May 27, 2024

@lornajane Unfortunately, with the ignore file approach, I end up with a problem similar to that described by #1224, as we generate multiple variants of our API (and furthermore, in our CI they are generated in temporary directories).

The solution in #1224 seems to be to create a custom plugin with an extension, but it is not clear to me how to write an extension for operation-2xx-response. Do you have any suggestions?

from redocly-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.