Giter Site home page Giter Site logo

Comments (5)

redphx avatar redphx commented on June 3, 2024

I think this is a bug on xCloud's side

from better-xcloud.

KingNothing81 avatar KingNothing81 commented on June 3, 2024

Hm, I don't think so. As soon as I had discovered that new option in the notification settings, I disabled "Notify me when I unlock an achievement". And never saw an achievment pop up again until I updated to 4.1.0 yesterday. So this would be a very big coincidence.

As I use "disable social features", I think this change was caused by your commit ba0ccf5 . Maybe whatever blocked the notification inbox from working before, was also blocking the achievement pop ups. And then your change in 4.1.0, that made the inbox work again, also unblocked the achievement pop ups again.

If that's really the case, you should make a feature out of this. Because many people also want to get rid of the achievement pop ups. Or maybe you can at least revert the change, As I prefer having a notification inbox that is not working, if this will keep away the achievement pop ups.

from better-xcloud.

KingNothing81 avatar KingNothing81 commented on June 3, 2024

I had a look at the code of commit ba0ccf5 and saw that with 4.1.0 you stopped blocking "https://notificationinbox.xboxlive.com", but are now blocking "https://xblmessaging.xboxlive.com/network/xbox/users/me/inbox'.

But if blocking "https://notificationinbox.xboxlive.com" really completely disabled the inbox and blocked all notifications (including the pop ups), you should really make an extra option out of this:

A "Do Not Disturb" (DND) mode for xCloud that people can enable. And that can be enabled independently from the "disable social features" option. I think this would be a very useful addition to the script.

from better-xcloud.

KingNothing81 avatar KingNothing81 commented on June 3, 2024

To further investigate, I turned off “disable social features” to see if it makes a difference. But it doesn’t. I just saw an achievement pop up again.

So you are right. It’s a bug on xCloud‘s side. Showing achievement notifications, although they are disabled in the notification settings.

But I think it’s also true that as long as you blocked “https://notificationinbox.xboxlive.com“, this also blocked the achievement pop ups for me. So I didn’t notice the bug before you unblocked it with 4.1.0.

This change really feels like a step back for me now. And I hope that you might really consider doing that DND mode. Because I think a feature, that lets users quickly enable/disable getting notifications at all, could be a useful addition for all users.

But as this really turned out to be a xCloud bug, I will close this now.

from better-xcloud.

KingNothing81 avatar KingNothing81 commented on June 3, 2024

A final update to this:

I used xCloud’s feedback option to report the issue several times now. But so far, it’s still unsolved.

So I created a filter rule in my router to block “https://notificationinbox.xboxlive.com” again. And enabled it for my Shield TV. And now the achievement pop ups are gone again. =)

As I thought, blocking that URL really seems to completely “disable” the inbox by blocking all incoming messages. Including the achievement toast messages.

So although I’ve found a way to solve this problem for me personally, I still think that adding a “DND mode” could also be a useful addition for other users.

from better-xcloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.