Giter Site home page Giter Site logo

Comments (4)

gaearon avatar gaearon commented on May 6, 2024

Please see if the issue is fixed in 0.6.0. We still don't give you props in the first function, but if the third function returns props shallowly equal to the previous props, no update should happen.

from react-redux.

maxguzenski avatar maxguzenski commented on May 6, 2024

yes! now it is working ... no re-render() :-)

from react-redux.

maxguzenski avatar maxguzenski commented on May 6, 2024

Just to know, you plan to give parent props to first function or you don't sure if it is a good thing?

from react-redux.

gaearon avatar gaearon commented on May 6, 2024

If everyone keeps asking about this, I'll consider it, but I also like that the API is symmetric.

There are some benefits to keeping it a function of single argument:

  1. The selector API stays simple. No need for things like reduxjs/reselect#20 that complicate sibling libraries to Redux.
  2. If you need to select state by props, most likely you'll need to inject props into action creators too. And you would be surprised if props were passed to the first function, but not to the second one. And we can't pass it to the second function because we only want to bind actions once for performant most common use case.

from react-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.