Done not being called if test fail in subscribe callback

[r1cebank]

Done not being called if test fail in subscribe callback

[r1cebank]

@arnaudbenard Thanks for looking into this, I just discovered this was caused by the way I wrote some part of the code.

[r1cebank]

I am using mocha 2.5.3, chai as my assertion library

[dmitry-zaets]

Can you please provide the code of your action and test including store preparation?
That would allow us to reproduce case.

[r1cebank]

I used test in your test folder

it('subscribes to dispatched actions', (done) => {
    const store = mockStore();
    const action = { type: 'ADD_ITEM' };

    store.subscribe(() => {
      expect('s').toEqual('a');
      done();
    });
    store.dispatch(action);
  });

so instead of failling the test, the test timeout, later I wrapped this with a try..catch and it worked that way. I wonder if that is the correct way to catch errors in store subscribe:

[arnaudbenard]

@r1cebank I ran you test locally and it failed, which version of node are you running?

➜  redux-mock-store (master) ✔ npm test

> [email protected] test /Users/arnaudbenard/Programming/redux-mock-store
> mocha --compilers js:babel/register --reporter spec test/*.js



  redux-mock-store
    1) subscribes to dispatched actions


  0 passing (722ms)
  1 failing

  1) redux-mock-store subscribes to dispatched actions:

      Error: Expected 's' to equal 'a'
      + expected - actual

      -s
      +a

      at Object.assert [as default] (node_modules/expect/lib/assert.js:20:9)
      at Expectation.toEqual (node_modules/expect/lib/Expectation.js:69:26)
      at Array.<anonymous> (test/index.js:143:19)
      at dispatch (src/index.js:40:25)
      at Object.dispatch (node_modules/redux-thunk/lib/index.js:15:14)
      at Context.<anonymous> (test/index.js:146:11)



npm ERR! Test failed.  See above for more details.

[r1cebank]

I am using node v6.0.0

[arnaudbenard]

@r1cebank I tried with node v6 and it works. You should push your repo with the code. I can't reproduce your error.