Comments (4)
You must provide correctly typed arguments for all of the input functions. As of Reselect 4.1, Reselect infers everything from those arguments.
Define (_state: RootState) => 5
(and similarly for any other arguments), and it will all work correctly!
from reselect.
You must provide correctly typed arguments for all of the input functions. As of Reselect 4.1, Reselect infers everything from those arguments.
Define
(_state: RootState) => 5
(and similarly for any other arguments), and it will all work correctly!
I do not understand why, with the new typings of createSelector
, it makes such a difference (whether to have a function inlined or defined separately). Also, as I said, it all used to work in v3, and this new requirement of having separate definitions is not explicitly stated neither in changelog nor in readme.
from reselect.
It's not about the "inline" or "defined separately".
It's literally that you must tell Reselect what the types of the arguments are.
// ❌ FAILS - no type for `state`
createSelector(
(state) => state.x,
output
)
// ✅ WORKS - TS knows the type of `state`
createSelector(
(state: RootState) => state.x,
output
)
Reselect's types now infer everything from those arguments, and tbh I'm not sure how this ever would have worked even with the old types if you don't provide any argument types at all.
from reselect.
Thank you for clarifications @markerikson , it seems to work correctly now with declared types of arguments. 🎉
from reselect.
Related Issues (20)
- unstable_autotrackMemoize Errors HOT 1
- How to type redux state and selectors with readonly? HOT 3
- Consider dev mode checks for `x => x` result functions HOT 2
- More Reselect addons to investigate HOT 1
- Add identifiable information to dev mode check log messages HOT 3
- Documentation ignores links in the table of contents entries HOT 1
- Type loss in `createSelector` with inline function declarations passed as separate arguments
- lastResult.deref is not a function (it is undefined) HOT 6
- Better call stack for selector warnings HOT 11
- Unable to use `resultEqualityCheck` with `weakMapMemoize` HOT 3
- Incorrect weakMapMemoize alternative example using useCallback HOT 1
- using createSelector.withTypes prevents build HOT 7
- Question: Why can't we support `createAsyncSelector`? HOT 7
- TypeError: (0 , _reselect.createSelector) is not a function HOT 12
- `weakMapMemoize` with `resultEqualityCheck` is provided empty objects for first call. HOT 3
- Library do not work in Safari < 14.1 HOT 1
- Why the LRUCache implementation is using Array over the Doubly Linked List with Map? HOT 8
- Question: should OutputSelector be used as an InputSelector? HOT 3
- Current documentration loose article about passing parameters HOT 1
- First level of cascading memoization is broken when more props are passed HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reselect.