Favicon support

[mojombo]

Favicon support

[cannikin]

In the meantime I tried including <link rel="icon" type="image/png" href="/favicon.png" /> in index.html but we don't have any way to serve static assets. :(

[mojombo]

Try including it in index.js:

import from './favicon.png'

That should get Webpack to include it.

[cannikin]

Yeah I tried that, no go. :( For stylesheets it actually transforms them into being inline <style> tags but in this case we're adding a <link> which makes a separate server request. Webpack doesn't know anything about that in dev mode unless you give it a directory to serve static assets from, I think?

[cannikin]

[cannikin]

We've got publicPath: '/' in webpack.config... hmm

[peterp]

I think you can add this:

new HtmlWebpackPlugin({
    favicon: "./src/favicon.png"
})

Over here: https://github.com/redwoodjs/redwood/blob/master/packages/scripts/config/webpack.config.js#L70-L72

We could also create a static/ or public/ folder that gets copied during build time, using copy-webpack-plugin, which might give us the most mileage.

[peterp]

Closed via #107