Duplicate Vue.js code

[redxtech]

Duplicate Vue.js code

[horoscop]

@sharq1 is right, could you please fix this @redxtech ?

Thanks!

[dominik-bln]

Importing Vue in index.js should likely not happen and also automatically registering on the global instance is a bit problematic. Usually this is handled with something like Vue.use(VuePlyr). See here for more details:

https://alligator.io/vuejs/creating-custom-plugins/#adding-capabilities

[sharq1]

Looks like it's 4.0.0 problem only, as 3.0.0 dist file has less than 400 lines total.

[redxtech]

I’ll definitely look into bundled vue code and development mode, but also can you tell me how you’re importing vue-plyr?

…

On Jul 30, 2018, at 04:21, Damian Duda ***@***.***> wrote: That seems like a bug to me, as ***@***.*** includes whole lot of Vue code. I'm new to Vue, but from JS standpoint that seems completely unnecessary and wrong, as this is why you would include Vue.js before including vue-plyr. What's worst is that I'm getting You are running Vue in development mode. message twice in console, which then finally leads to: Unknown custom element: <vue-plyr> - did you register the component correctly? If I'm however wrong and it's my fault, then please excuse me - as I mentioned, I'm new to Vue ;) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[sharq1]

Hi @redxtech
Thank you for looking at this.
I think I know what my problem with registering is...
I'm using default Rails assets pipeline which makes your lib break at require. Solution would be to use webpacker gem. Nothing that you can do I guess :)

[irazasyed]

Created a PR based on @dominik-bln's suggestion. Hopefully, it'll be merged soon. Ref: #31. Open for suggestions, will make changes accordingly if required.

This issue has been bothering me as well :P

[redxtech]

A PR has been proposed to fix this. I'll take a look and see if it works today.

[redxtech]

Just requested a few changes from the PR from @irazasyed and when they are implemented I will merge.