Giter Site home page Giter Site logo

CJS incompatible about vue-plyr HOT 10 CLOSED

redxtech avatar redxtech commented on July 1, 2024 3
CJS incompatible

from vue-plyr.

Comments (10)

akarelas avatar akarelas commented on July 1, 2024

I agree with @iCrawl . The title of her issue could also be called 'nuxt incompatible'.

Without her fix, vue-plyr doesn't work on nuxt. With her fix it does.

Could you take it into consideration?

from vue-plyr.

redxtech avatar redxtech commented on July 1, 2024

Yippee another breaking issue!

I'll take a look at this and see what we can do to make this work with SSR.

from vue-plyr.

redxtech avatar redxtech commented on July 1, 2024

I'm working on this one right now. Sorry for the wait.

from vue-plyr.

redxtech avatar redxtech commented on July 1, 2024

I'm working on fixing this one right now. It's taking a little bit of time to work out all types of compatibility but once I get vue-cli & nuxt worked out I will push a new version with this fix.

from vue-plyr.

redxtech avatar redxtech commented on July 1, 2024

I have pushed a fix to npm (v5.1.0) that should fix this issue. Sorry for the long wait I just had a bunch of personal stuff going on. @iCrawl test it out and let me know the results.

from vue-plyr.

rhwilr avatar rhwilr commented on July 1, 2024

@redxtech Thanks for fixing the issue.
I tried to test it out, but the latest release on npm is 5.0.4.

from vue-plyr.

redxtech avatar redxtech commented on July 1, 2024

Whoops forgot to publish it. @rhwilr should be updated now. Try again.

from vue-plyr.

rhwilr avatar rhwilr commented on July 1, 2024

👍 Perfect! now it works
And at least for me the issue seems to be fixed 🎉
Thanks for the great work!

from vue-plyr.

redxtech avatar redxtech commented on July 1, 2024

Sounds good. I'll close this issue in a day or two if no one has any problems. If you do have problems let me know and I'll try to fix them and won't close it until those are finished.

from vue-plyr.

redxtech avatar redxtech commented on July 1, 2024

Ok since there have been no problems yet I will close this issue. Let me know if anything pops up.

from vue-plyr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.