Giter Site home page Giter Site logo

Comments (3)

yk-eukarya avatar yk-eukarya commented on September 3, 2024

In the design link there is a case for custom theme, so
we have 2 main cases:

  • pre-made theme
  • custom theme

So I'm thinking about do not deal with those cases in the backend side, instead the backend always interact with themes as custom themes, and the pre-made theme can be declared in the front end side

Also can we treat the "themeConfig" object as a scene property?

@rot1024 @HideBa

from reearth-visualizer.

HideBa avatar HideBa commented on September 3, 2024

@yk-eukarya

So I'm thinking about do not deal with those cases in the backend side, instead the backend always interact with themes as custom themes, and the pre-made theme can be declared in the front end side

I also think that's a better way.

Also can we treat the "themeConfig" object as a scene property?

I think it's OK.

@rot1024 How do you think?

from reearth-visualizer.

rot1024 avatar rot1024 commented on September 3, 2024

It depends on the requirements of the feature.

If you don't need to customize the theme at all, it is enough to create a theme field in the scene property and store the theme identifier.

If you want to be able to customize the theme, you need to design a separate domain model, and the scene will have that model.

However, it is also possible to customize the theme using only properties. In that case, there is no need for a new domain model and UI for theme customization.

- id: theme
  fieds:
    - id: theme_base
      title: Theme
      type: string
      choices:
         - key: default
           label: Default
    - id: theme_color_primary
      title: Primary color
      type: string
      ui: color
# ...

from reearth-visualizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.