Comments (3)
In the design link there is a case for custom theme, so
we have 2 main cases:
- pre-made theme
- custom theme
So I'm thinking about do not deal with those cases in the backend side, instead the backend always interact with themes as custom themes, and the pre-made theme can be declared in the front end side
Also can we treat the "themeConfig" object as a scene property?
from reearth-visualizer.
So I'm thinking about do not deal with those cases in the backend side, instead the backend always interact with themes as custom themes, and the pre-made theme can be declared in the front end side
I also think that's a better way.
Also can we treat the "themeConfig" object as a scene property?
I think it's OK.
@rot1024 How do you think?
from reearth-visualizer.
It depends on the requirements of the feature.
If you don't need to customize the theme at all, it is enough to create a theme field in the scene property and store the theme identifier.
If you want to be able to customize the theme, you need to design a separate domain model, and the scene will have that model.
However, it is also possible to customize the theme using only properties. In that case, there is no need for a new domain model and UI for theme customization.
- id: theme
fieds:
- id: theme_base
title: Theme
type: string
choices:
- key: default
label: Default
- id: theme_color_primary
title: Primary color
type: string
ui: color
# ...
from reearth-visualizer.
Related Issues (20)
- Plugin API to communicate with other plugins
- UI to show current policy and error message if reach to the limit
- [FE]: Plugin API to communicate with other plugins
- [FE]: Extend plugin API to get query parameters
- [FE]: Extend plugin API with client storage
- Earth terrain won't be displayed when using pre-built docker image
- Create slides in the infobox
- マーカー機能でポイントした位置とマーカーの表示位置が地図の表示場所移動時にずれる。Marks move from the positions pointed by the marker function when the position is moved
- 3Dタイルと画像について About 3Dtiles and pictures
- マーカー位置を切り替える途中、背景地図にエラーが生じる
- リアースのインフォボックスが表示されない。
- 目的地にアクセスするための検索窓の設置について HOT 1
- 場所の検索機能の提案
- マーカーに画像を添付する際に起きる問題について Error in attaching image to marker
- 建物を探すときに基準が欲しい(I want criteria when searching for a building.)
- 場所検索機能をつくってほしい
- 自分の知りたい場所をすぐに分かるようにして欲しい HOT 1
- PLATEAUの3D建物モデルを入れた際、マーカーの高さを建物の高さに位置できるようにしてほしい
- 建物にピンを指すときの曖昧さについて
- PLATEUの3Dモデルを入れた際に生じるバグを改善してほしい
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reearth-visualizer.