Comments (6)
Making one by hand is a bit icky in my opinion. I think I'd rather remove our default
exports. I guess it's arguable that it's not a breaking change, because consumers shouldn't really have been trying to use anything other than the single point of entry into the module, and so long a that stays consistent, then it's fine. Or we just bump to v3 anyway. I guess it doesn't matter too much.
from quill-cursors.
I've had a very quick look at this, but getting the TypeScript definitions to play nicely with Webpack appears to be non-trivial. I've tried the following with no success:
declaration-bundler-webpack-plugin
, which doesn't build properly. I tried with this fix, which generates a declaration, but it doesn't appear to be valid- this StackOverflow answer which potentially gets a little closer, but still doesn't work
dts-bundle-webpack
which is a neater version of the above StackOverflow solution
I think this isn't working because we use default
exports, which don't work very well when being combined into a single d.ts
file. We could potentially move away from that, but it would be a breaking change, so I'd be inclined to leave it for if we want to make more big changes.
I probably don't have a lot of time to look into this, as it's a nice-to-have. Please feel free to raise a PR if you think you can crack it, though.
from quill-cursors.
A trivial but ugly solution (until it is possible to move away from default exports) would be making a definition file by hand. As there are not that many methods this should be very easy and quick. Thoughts on that?
from quill-cursors.
Or we just bump to v3 anyway. I guess it doesn't matter too much.
Yeap. If it can be breaking better to bump, IMO.
from quill-cursors.
Should now hopefully be fixed by #54
Release coming soon.
from quill-cursors.
@alecgibson, can't wait for release!
from quill-cursors.
Related Issues (20)
- setStart error HOT 3
- Using with react-quill, cursors stays hidden HOT 2
- ql-cursor-selections span renders `null` (text) on Edge browser HOT 2
- Flags can be cropped by parent containers and viewports HOT 1
- Move during transformation can lead to wrong result HOT 8
- IndexSizeError after inserting image and then selecting everything in the editor HOT 3
- Incorrect positioning of cursors inside css transformed quill HOT 7
- Cursor appears on next line after typing (sometimes) HOT 4
- Quill-cursors has a memory leak due to missed cleanup for global listeners HOT 5
- Cursors work great, but lose flags after a remount with React HOT 5
- Other user's cursor position prevents clicking on link text. HOT 3
- Other user's cursor shows over scrollable content. HOT 2
- Can't touch near other user's cursors HOT 1
- Engine requirement HOT 2
- Using a quill editor inside a react-flow is somehow causing cursors to render at strange places. HOT 9
- Newlines in html template in minified js? HOT 5
- Unable to Build Project With Quill-Cursors imported HOT 2
- Cursor position is incorrect when direction is RTL
- quill-cursors and quill's bubble toolbar have conflicting requirements for scrollable editor HOT 8
- Quill v2 Support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quill-cursors.