Giter Site home page Giter Site logo

Add typings about quill-cursors HOT 6 CLOSED

reedsy avatar reedsy commented on July 27, 2024
Add typings

from quill-cursors.

Comments (6)

alecgibson avatar alecgibson commented on July 27, 2024 2

Making one by hand is a bit icky in my opinion. I think I'd rather remove our default exports. I guess it's arguable that it's not a breaking change, because consumers shouldn't really have been trying to use anything other than the single point of entry into the module, and so long a that stays consistent, then it's fine. Or we just bump to v3 anyway. I guess it doesn't matter too much.

from quill-cursors.

alecgibson avatar alecgibson commented on July 27, 2024

I've had a very quick look at this, but getting the TypeScript definitions to play nicely with Webpack appears to be non-trivial. I've tried the following with no success:

I think this isn't working because we use default exports, which don't work very well when being combined into a single d.ts file. We could potentially move away from that, but it would be a breaking change, so I'd be inclined to leave it for if we want to make more big changes.

I probably don't have a lot of time to look into this, as it's a nice-to-have. Please feel free to raise a PR if you think you can crack it, though.

from quill-cursors.

RobbinBaauw avatar RobbinBaauw commented on July 27, 2024

A trivial but ugly solution (until it is possible to move away from default exports) would be making a definition file by hand. As there are not that many methods this should be very easy and quick. Thoughts on that?

from quill-cursors.

pedrosanta avatar pedrosanta commented on July 27, 2024

Or we just bump to v3 anyway. I guess it doesn't matter too much.

Yeap. If it can be breaking better to bump, IMO.

from quill-cursors.

alecgibson avatar alecgibson commented on July 27, 2024

Should now hopefully be fixed by #54

Release coming soon.

from quill-cursors.

vlazh avatar vlazh commented on July 27, 2024

@alecgibson, can't wait for release!

from quill-cursors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.