Giter Site home page Giter Site logo

Comments (8)

rhaamo avatar rhaamo commented on May 29, 2024

moving them where ?

The documentation for prod and dev already document how to do it, dev on the root and prod in deploy.
Plus the respective Dockerfiles should stay in the respective folder they represent.

from reel2bits.

albjeremias avatar albjeremias commented on May 29, 2024

I really like the approach of mastodon... they have the docker-compose.yml and the Dockerfile on the root...
why have 2 different dockerfiles? thats more code to maintain...

and this installation of docker described in: https://docs-develop.reel2bits.org/installation/docker.html is just a hassle... when it could be just

$ git clone repo
$ docker-compose up

from reel2bits.

rhaamo avatar rhaamo commented on May 29, 2024

dev.yml permits to have multiple instances prefixed with they own name etc. which is useful in dev.

the one in deploy only have the requirements for prod.

plus reverse proxy is different from prod and env, there is really a lot of difference when developping rather than prod.

from reel2bits.

albjeremias avatar albjeremias commented on May 29, 2024

hm, it sounds like the prod should be the default one.. and that there should be an extra one, for multiple instances?
the reverse proxy should not be handled by reel2bits at all... all this traefik settings should not belong to reel2bits

from reel2bits.

rhaamo avatar rhaamo commented on May 29, 2024

we don't use traefik but nginx, and there is the need for it for serving the frontend, assets or medias correctly.

there is real differences between the dev and prod docker-compose files, I prefers to have separated files to not confuse things, you either run a dev, or a prod, not doing both, and if you do both, you know what you are doing and that's not an issue.

from reel2bits.

albjeremias avatar albjeremias commented on May 29, 2024

this is what i meant about traefik..
https://github.com/reel2bits/reel2bits/blob/master/dev.yml#L122

from reel2bits.

rhaamo avatar rhaamo commented on May 29, 2024

@albjeremias leftover from what I've used as a base.

I will remove it later and someone can import it back if wanted.

from reel2bits.

albjeremias avatar albjeremias commented on May 29, 2024

Peertube has a structure closer to what you have.. might give inspiration:

https://github.com/Chocobozzz/PeerTube/tree/develop/support

And are using traefik.. which is interesting.. but im not used to.. lets try it ;)

from reel2bits.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.