Revise API?

[reflux]

Revise API?

[dashed]

Usage with example from README:

var Reflux = require('Reflux');

/**
 * Actions
 */
var status = new Reflux.Actions(['update', 'edit', 'add']);

/**
 * Store
 */
var statusStore = new Reflux.Store();

statusStore.on(status.update, function(flag) {

    var status = flag ? 'ONLINE' : 'OFFLINE';

    this.done(status);
});

/**
 * Component
 */
var Status = React.createClass({
    initialize: function() { },
    onStatusChange: function(status) {
        this.setState({
            currentStatus: status
        });
    },
    componentDidMount: function() {
        this.unsubscribe = statusStore.listen(this.onStatusChange);
    },
    componentWillUnmount: function() {
        this.unsubscribe();
    },
    render: function() {
        // render specifics

        status.update(true);
    }
});

[spoike]

Yeah, second snippet of code now makes much more sense than the PR from earlier (i.e. #13).

I'd love it more if the on function in stores can accept other store's as well to be able to do the aggregate store story. I still see value in passing in a constructor object to Reflux.Store as in Reflux.createStore.

Also I believe we can add aliases if users find it more suitable to use Reflux.Store instead of Reflux.createStore, Reflux.Actions instead of Reflux.createActions, and Store.on instead of Store.listenTo.

I think it was a bit of a mistake to pass in an array to Reflux.createActions earlier when Reflux might as well can use the arguments object with strings instead. I.e. instead of:

var status = Reflux.Actions(["update", "edit", "add"]);

... it should be able to do the same like this:

var status = Reflux.Actions("update", "edit", "add");

[dashed]

on function in stores should already accept either action or stores. Same applies for dependencies.

---

Passing context object to Reflux.Store probably makes sense:

var obj = {};
obj.cowSound = 'moo';
obj.moo = function(some, args, done) {

    console.log(this.cowSound);

    done(result);
};


var statusStore = new Reflux.Store(obj);

statusStore.on(status.update, obj.moo);

---

Agreed that parameters shouldn't be an array.

[vslinko]

👎