Option to remove external nodes?

[ejmount]

Option to remove external nodes?

[regexident]

Hi Ewan,

would you by chance be able to provide a minimal(!) reproducible main.rs file along with the actual, as well as expected output? I'm not exactly sure what you mean, so some real code would help greatly. 🙂

[ejmount]

Given a file like this, with appropriate Cargo.toml

struct AThing;

pub mod alpha {
    use delta::ATrait;
    pub mod beta {
        use crate::AThing;
        use chrono::DateTime;

        pub struct AnotherThing {
            dt: chrono::Duration,
        }

        pub mod gamma {

            use rand::CryptoRng;
        }
    }
    pub mod delta {
        use super::beta::AnotherThing;
        use rand::Rng;

        pub trait ATrait {}


    }

}

And running cargo modules generate graph --with-types --with-uses --with-traits --layout dot | dot -Tpng -O, I get this:

When what I actually want is something like this:

In particular I want to keep the uses links in between modules in the current crate, while removing the ones pointing to external items. Removing the --with-uses parameter removes the external items, but also removes the links inside the crate.

[regexident]

@ejmount Hm, when I run the same command I get exactly what you "actually want":

I've added a corresponding snapshot test here: #175

Are you sure you didn't accidentally also add --with-externs? Nodes with "external" should only ever get generated if --with-externs was provided.

[visd0m]

I have the same issue, don't know If I can help somehow.

[SebastianHambura]

I've tried running cargo modules generate graph --types --uses --traits --layout dot --no-externs | dot -Tpng -O and cargo modules generate graph --types --uses --traits --layout dot | dot -Tpng -O and i both cases I get the same (wrong) result as @ejmount

In case it helps, on my setup I have :

• cargo-modules v0.9.0
• rustc 1.67.1
• cargo 1.67.1