Comments (11)
I've requested some clarification in dotnet/roslyn#44201.
from editorconfig.
@Xeevis You may be right. My initial understanding was that 16.8 would bring in the breaking changes. It seems to work too but not for some settings.
I'll get #43 fixed and if that doesn't resolve the issue we should revert PR dotnet/roslyn#44201.
from editorconfig.
Are you using the latest version of VS? There were breaking changes are called out in #42.
from editorconfig.
This is my VS Version (About dialog) Microsoft Visual Studio Professional 2019 Version 16.8.2
from editorconfig.
I tried it and you're correct.
The EditorConfig VS extension is complaining that csharp_*
and dotnet_style_
properties need a severity and others don't. I don't really understand what's going on.
According to dotnet/roslyn#39827 this change should have gone out already.
dotnet/roslyn#48580 suggests that there were further changes to go out in 16.9.
from editorconfig.
I have same problem with Visual Studio Code using Omnisharp. it had Roslyn updated to 3.8.0 2 days ago and it doesn't take into account any rules missing severity either.
from editorconfig.
#43 may be the cause of this issue.
from editorconfig.
Ran into the same thing today.
I have to explicitly set the severity for it to behave correctly:
csharp_style_var_for_built_in_types = true:suggestion
csharp_style_var_when_type_is_apparent = true:suggestion
csharp_style_var_elsewhere = true:suggestion
Otherwise these settings are not picked up at all.
from editorconfig.
@cars10w Did fixing #43 fix this issue for you?
from editorconfig.
@RehanSaeed What fix do you exactly mean?
from editorconfig.
I think 2.0.0 breaking changes were released way ahead of their time. Current syntax isn't deprecated yet, the #44201 issue isn't closed, it's just a backlog not even planned for 16.9.
PR Make the ':severity' suffix in editorconfig code style value optional milestoned for 16.9 Preview 2 that released yesterday just makes the current syntax optional.
from editorconfig.
Related Issues (20)
- Suggestion: dotnet new tool HOT 4
- Improved .editorconfig compliance with .NET guidelines HOT 26
- Add Sample Project HOT 3
- File Header Comments
- A severity must be specified on modifier preferences HOT 1
- Renaming master Branch to main HOT 1
- Wrong scope for dotnet severity HOT 1
- Upgrade to new Severity Syntax for VS 16.9 HOT 13
- New Settings in VS 16.10 HOT 3
- Adding .editorconfig breaks TreatWarningsAsErrors HOT 6
- New Settings in VS 16.11 HOT 6
- Support for .razor files HOT 3
- Version 4.1.0 still says "4.0.0" on the file header HOT 1
- Is there a rule to control empty line between class members declaration HOT 2
- New Spell Check Setting HOT 1
- Is there a way to enforce const to be real Pascal Case only? HOT 1
- New Formerly Experimental Settings HOT 1
- Add .cshtml to Web Files Indent Config
- Support New Settings HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from editorconfig.