Giter Site home page Giter Site logo

Comments (2)

johningve avatar johningve commented on June 2, 2024

One problem with passing QuorumSpec as an interface{} is that we won't get any compiler errors if the qspec object doesn't implement the QuorumSpec interface.

If the main idea is to get rid of the qspec argument in NewConfiguration when there are no quorum functions, then we could instead use templates to omit the qspec argument when it is not needed. That way we keep the compile-time type checking.

from gorums.

meling avatar meling commented on June 2, 2024

I prefer not to generate a separate NewConfiguration method with a different signature for methods that don't use the QuorumSpec.

PR #122 implements a non-type safe approach. A draft generics idea is sketched here. However, we could do better with generics, e.g., I think we can do a single With[Type]() method.

from gorums.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.