Giter Site home page Giter Site logo

Comments (8)

remarkablemark avatar remarkablemark commented on September 26, 2024 2

Thanks for opening this issue @ssi02014! I do plan to eventually migrate to TypeScript but that will be a breaking change this for library.

from html-react-parser.

remarkablemark avatar remarkablemark commented on September 26, 2024 1

@ssi02014 Yes if we're using TypeScript, then we'll be using ES6 syntax.

from html-react-parser.

remarkablemark avatar remarkablemark commented on September 26, 2024 1

Release:

from html-react-parser.

ssi02014 avatar ssi02014 commented on September 26, 2024 1

🎉🎉🎉

from html-react-parser.

ssi02014 avatar ssi02014 commented on September 26, 2024

@remarkablemark 👍
Thanks for the review!
So, am I correct in understanding that you don't need to do the "let/const" migration beforehand?

as-is

// attributes-to-props.js
var reactProperty = require('react-property');
var utilities = require('./utilities');

// https://reactjs.org/docs/uncontrolled-components.html
// https://developer.mozilla.org/docs/Web/HTML/Attributes
var UNCONTROLLED_COMPONENT_ATTRIBUTES = ['checked', 'value'];
var UNCONTROLLED_COMPONENT_NAMES = ['input', 'select', 'textarea'];

var VALUE_ONLY_INPUTS = {
  reset: true,
  submit: true
};

// ...

to-be

// attributes-to-props.js
const reactProperty = require('react-property');
const utilities = require('./utilities');

// https://reactjs.org/docs/uncontrolled-components.html
// https://developer.mozilla.org/docs/Web/HTML/Attributes
const UNCONTROLLED_COMPONENT_ATTRIBUTES = ['checked', 'value'];
const UNCONTROLLED_COMPONENT_NAMES = ['input', 'select', 'textarea'];

const VALUE_ONLY_INPUTS = {
  reset: true,
  submit: true
};

// ...

from html-react-parser.

ssi02014 avatar ssi02014 commented on September 26, 2024

@remarkablemark
Thanks! 👍👍👍

from html-react-parser.

kasperaamodt avatar kasperaamodt commented on September 26, 2024

@remarkablemark any updates on the progress here?

from html-react-parser.

remarkablemark avatar remarkablemark commented on September 26, 2024

@kasperaamodt No update at the moment. I've been pretty busy so I haven't had a chance to work on this.

from html-react-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.