Giter Site home page Giter Site logo

Comments (4)

rembo10 avatar rembo10 commented on August 16, 2024

For sure. I'm working on a better filter that'll actually analyze the results, get rid of low scoring matches, etc. But I don't want to filter out relevant results - that's why this version includes the top 10 i think it is.

Some additional info would be good, but I'd have to do a new query for each artist in the search results which would take 1 second per artist (sleeping per MusicBrainz rules)

On Jun 24, 2011, at 2:32 PM, [email protected] wrote:

If for example, you do a search for artist (or add an artist), e.g. Enigma, it returns four Enigma's, three containing no albums. It happens with more artists (e.g. Bonobo, which returns 2, 1 without albums).

It needs a check if there are albums found for an artist, before it shows the artists on http://localhost:8181/findArtist?name=enigma, or perhaps shows the amount of albums found behind it like so:
Enigma (more info) 4 albums
Enigma (more info) 0 albums
Enigma (more info) 0 albums
Enigma (more info) 1 album

Now the only check is if there is a result (result is artistname). If no results, it shows a blank page. If there are results, it shows the artists, but the user needs to click all results to see which one of the artists (if all the same) contains the albums and that's the one that needs to be added.

Reply to this email directly or view it on GitHub:
#17

from headphones.

Mar2zz avatar Mar2zz commented on August 16, 2024

A test, query Adele:
returns:
Search returned multiple artists. Click the artist you want to add:
Adèle (more info)
Adele (more info)
Adele (more info)
Adèle Bloemendaal (more info)
Adele Overton (more info)
Adele Holness (more info)
Adele Sebastian (more info)
Adele Nozedar (more info)
(results are coming from: http://musicbrainz.org/search?query=adele&type=artist, which is good)

Only the first 3 have my interest, and score 100 on MB):

  1. French artist, 2 albums on Mb, not showing albums in Headphones (so it's empty)
  2. Melodic hardcore band, 1 EP on Mb, not showing in Headphones (empty also)
  3. UK Soul/Jazz Singer, showing 2 albums, which is ok, though more things are released, and it's showing 21 three times...

Solution to make it more obvious which artist is returned by the search, als include description (see link Musicbrainz for that):
Adèle (french artist) (more info)
Adele (A Melodic Hardcore band) (more info)
Adele (UK Soul/Jazz singer) (more info)

Or if for example a query for Bonobo:
Bonobo (UK electro artist Simon Green) (more info)
Bonobo (Dutch breakbeat group) (more info)

from headphones.

rembo10 avatar rembo10 commented on August 16, 2024

The only thing is, I don't want to exclude any artists that you might be interested in in the manual search. The automatic search just picks the best result, but the manual search should be pretty inclusive. I think adding the disambiguation (i.e. 'UK Soul/Jazz singer') is the best solution.

I was thinking about how to make the search smarter, for example you may have one result with a score of 100, and then others with a lower score, or you may have multiple results with a score of 100, or you may have no results with a score of 100.

Then based on these three circumstances, it would show different results (filter out low scoring results, etc), or simply just add the artist.

from headphones.

rembo10 avatar rembo10 commented on August 16, 2024

I added disambiguation to the search results - should make things way easier

A search for Adele now returns:

Search returned multiple artists. Click the artist you want to add:

Adèle (french artist) (more info)
Adele (A Melodic Hardcore band) (more info)
Adele (UK Soul/Jazz singer) (more info)

from headphones.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.