Comments (3)
In packages/sw/src/message/precacheHandler.ts
The
assetCache
is not initialized, resulting in a cache namedrp-undefined
being created.Unlike
dataCache
anddocumentCache
the corresponding asset variable is not initialized withthis.assetCacheName
. Thenthis.assetCacheName
is checked if it's a string, but the always undefinedassetCache
variable is used to open the cache.For some reason there is a
@ts-expect-error
which hides this error.
Thanks for spotting this! I am currently re-writing sw
on the feat/vite
branch. And caching is one of the main reasons for doing so, including deprecation of cache
package 👍
from monorepo.
Update: Issues hasn't been forgotten. Just drowning in work atm, hope to be back in a few weeks 👍
from monorepo.
Removed support for esbuild
, so this issue won't be fixed
Precaching support in Vite is present, but no utility yet from remix-pwa
. Would be providing solutions soon
from monorepo.
Related Issues (20)
- ESM Directory Import error with Remix 2 base template HOT 4
- Wrong conditionals used in compiler HOT 2
- Usage with Vite HOT 6
- Getting started not working properly HOT 4
- Running `remix vite:dev` throws rollup plugin error HOT 1
- Trying to build project throws error on [vite-plugin-remix-pwa:virtual-entry-sw] HOT 5
- Cannot initialize app in v4 HOT 1
- Error and Failure in Creating entry.worker.ts during Remix PWA Upgrade HOT 5
- Incorrect sourmap on build due to plugin vite-plugin-remix-pwa:loader HOT 8
- Implementing push notifications HOT 4
- "@remix-pwa/push": "^1.0.2" is missing HOT 2
- how to setup Offline Page using remix-pwa HOT 3
- Server is crashing, no service worker being built, redeclaration of variable. HOT 1
- Uncaught SyntaxError: Unexpected token 'export' (at entry.worker.js:5666:1) HOT 7
- __workerManifest.assets is missing entry for manifest-{version}.js HOT 1
- Todo: Migrate to Biome
- Can't call `npx remix-pwa sw` HOT 4
- Question: remix-pwa inside electron HOT 1
- Consider Remix v2 during `remix-pwa init` run HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monorepo.