Comments (4)
I believe the best and simplest solution to this issue would be to use window.history.back()
in the piece of code that handles cancelled transitions. This would effectively change the URL back to whatever it was before the transition started, and it would preserve the ability to manually enter a new URL into the location bar (as opposed to requiring all URL changes to go through transitionTo
, for example).
In this solution, the router that aborted the transition should remain unaffected by the URL change because it would never actually update its components properties. The problem with this approach would be with other routers on the same page that are also observing the URL. They would effectively see two changes to the URL in quick succession, which would probably cause some weirdness.
The best way to solve this would be to use a dispatcher singleton that is responsible for listening to the URL and dispatching transition objects to routers that need to know about URL changes. When the URL changes, it would dispatch a new Transition
and wait for all transition hooks to resolve before actually telling routers to proceed with the transition and update their components.
from react-router.
The "transitions" example code runs fine with this commit.
from react-router.
It's actually one better than Ember's router because the URL is always kept in sync with what is on the page, even when it is manually changed but the transition is aborted.
from react-router.
:fistpump:
On Wed, Jun 11, 2014 at 9:34 AM, Michael Jackson [email protected]
wrote:
It's actually one better than Ember's router because the URL is always
kept in sync with what is on the page, even when it is manually changed but
the transition is aborted.—
Reply to this email directly or view it on GitHub
#22 (comment)
.
from react-router.
Related Issues (20)
- [Docs]: Tutorial missing imports within 'contacts.js'. [ "match-sorter" , "localforage" , "sort-by" ] HOT 1
- [Bug]: history.listen not triggered on hash changes HOT 1
- [Bug]: Update comments recommending to use polyfill.io HOT 3
- [Docs]: Nested Routes are essentially undocumented HOT 5
- [Bug]: unstable_patchRoutesOnMiss is superseded by "*" (404) HOT 3
- [Bug]: unstable_patchRoutesOnMiss leaf ignored when patching sub-trees asyncronously HOT 3
- [Bug]: Functional updates to `useSearchParams` don't get updated values HOT 2
- Update to isbot@5 HOT 1
- [Bug]: `unstable_patchRoutesOnMiss` remote module error-handling HOT 13
- [Bug]: useMatch does not decode params HOT 4
- [Bug]: Could not resolve './utils' from packages/router/index.ts HOT 2
- [Bug]: Link when used with Outlet is not working. It is routing to error page when clicked. HOT 1
- [Bug]: setSearchParams from useSearchParams remove hash HOT 1
- [Bug]: HashRouter need to wrapped twice HOT 1
- [Docs]: docs show reach/router instead of react/router HOT 2
- [Bug]: "react-router-dom-v5-compat" <CompatRouter> doesn't unsubscribe from history potentially causing tests to memory leak HOT 2
- [Bug]: child loader redirect overrides parent loader error HOT 7
- [Bug]: v7_partialHydration with unstable_patchRoutesOnMiss: hydrateFallbackElement not shown on patched routes HOT 3
- [Bug]: Relative path does not work as expected in outlets HOT 1
- [Bug]: useNavigate causes component to rerender HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.