Giter Site home page Giter Site logo

Comments (6)

mjackson avatar mjackson commented on March 28, 2024

Extra props (i.e. not handler, name, or path) that are passed to <Route> components should still be passed to their handlers. Can you post some sample code or even better a failing test that demonstrates this is failing?

from react-router.

mjackson avatar mjackson commented on March 28, 2024

I should also mention that key, params, query, and activeRoute are reserved prop names, so if your "static" props are named any of those they will be overwritten.

from react-router.

bjyoungblood avatar bjyoungblood commented on March 28, 2024

I was mistaken. It's actually just the top-level route that does not receive static props. #29 has a failing test and a fix.

from react-router.

mjackson avatar mjackson commented on March 28, 2024

@bjyoungblood Awesome. Thank you. I'll follow up on #29.

from react-router.

torgeir avatar torgeir commented on March 28, 2024

Extra props (i.e. not handler, name, or path) that are passed to components should still be passed to their handlers.

@mjackson Does this mean that the following ought to be working? https://gist.github.com/torgeir/7d14a2b42019603aef1e

from react-router.

abergs avatar abergs commented on March 28, 2024

For others encountering this; @torgeir behavior changed in 0.11, see https://github.com/rackt/react-router/blob/master/UPGRADE_GUIDE.md#route-props-passed-to-handlers

from react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.