Comments (7)
Seems like we should allow any valid uri between forward slashes.
Sent from my iPhone
On Jun 29, 2014, at 6:45 PM, Chris Lee [email protected] wrote:
I'd like to have a match based on a param that contains a period, instead of using the period as a separator and therefore considering it as two separate params. Possible?
—
Reply to this email directly or view it on GitHub.
from react-router.
Here's an example. If I have a route set up like
<Route name="thing" path=":param" handler={thing} />
and then go to
localhost:3000/#foo.bar
(Detail: I'm using hash-based routes.)
I get a warning:
Warning: No route matches path "foo.bar". Make sure you have <Route path="foo.bar"> somewhere in your routes
but if I change the route to
<Route name="thing" path=":param1.:param2" handler={thing} />
then the route gets matched and I get foo
as param1
and bar
as param2
, but I just one one param equal to foo.bar
.
from react-router.
Currently, :paramName
-style placeholders match everything up to a .
, /
, ?
, or #
. The idea was that you might want to have a pattern like /files/:filename.:ext
and you could get the filename
and ext
in two separate params. However, of those 4 chars, I'd agree that .
feels the most out of place. It's definitely significant in file paths, but a little less so in URLs.
Ultimately this is just a matter of preference. I'd be ok to switch the behavior if everyone wants to.
from react-router.
Hm, I can see the reason for the current behavior. It's pretty inconvenient for what I'm doing, though, since I'm checking strings in the params that just happen to contain a period. I think I'll fork for my own use, at least.
from react-router.
@cleercode It's literally just removing the .
char from that RegExp
.
@rpflorence What's your feeling?
from react-router.
This is the second time it's come up, and I anticipate it'll be problem when we bring the router in for a file browser UI we're working on right now.
I think . makes more sense as a character than delimiter.
Sent from my iPhone
On Jun 30, 2014, at 12:00 AM, Michael Jackson [email protected] wrote:
@cleercode It's literally just removing the . char from that RegExp.
@rpflorence What's your feeling?
—
Reply to this email directly or view it on GitHub.
from react-router.
@rpflorence Yeah, I agree.
@cleercode You want to make a PR? :)
from react-router.
Related Issues (20)
- [Docs]: Tutorial missing imports within 'contacts.js'. [ "match-sorter" , "localforage" , "sort-by" ] HOT 1
- [Bug]: history.listen not triggered on hash changes HOT 1
- [Bug]: Update comments recommending to use polyfill.io HOT 3
- [Docs]: Nested Routes are essentially undocumented HOT 5
- [Bug]: unstable_patchRoutesOnMiss is superseded by "*" (404) HOT 3
- [Bug]: unstable_patchRoutesOnMiss leaf ignored when patching sub-trees asyncronously HOT 3
- [Bug]: Functional updates to `useSearchParams` don't get updated values HOT 2
- Update to isbot@5 HOT 1
- [Bug]: `unstable_patchRoutesOnMiss` remote module error-handling HOT 13
- [Bug]: useMatch does not decode params HOT 4
- [Bug]: Could not resolve './utils' from packages/router/index.ts HOT 2
- [Bug]: Link when used with Outlet is not working. It is routing to error page when clicked. HOT 1
- [Bug]: setSearchParams from useSearchParams remove hash HOT 1
- [Bug]: HashRouter need to wrapped twice HOT 1
- [Docs]: docs show reach/router instead of react/router HOT 2
- [Bug]: "react-router-dom-v5-compat" <CompatRouter> doesn't unsubscribe from history potentially causing tests to memory leak HOT 2
- [Bug]: child loader redirect overrides parent loader error HOT 7
- [Bug]: v7_partialHydration with unstable_patchRoutesOnMiss: hydrateFallbackElement not shown on patched routes HOT 3
- [Bug]: Relative path does not work as expected in outlets HOT 1
- [Bug]: useNavigate causes component to rerender HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.