Comments (8)
I'm not opposed to this, though it seems like #52 should be solved by using a transition.redirect( ... )
in the willTransitionTo
hook of the route handler. I'm not sure it represents a good use case.
from react-router.
To clarify, the PostPage
handler from #52 could have looked like this:
var PostPage = React.createClass({
statics: {
paramsAreValid: function (params) {
// ...
},
willTransitionTo: function (transition, params) {
if (!PostPage.paramsAreValid(params))
transition.redirect('404');
}
}
});
Of course, this requires you to create your own paramsAreValid
method for each route handler.
But also, consider the case where paramsAreValid
succeeds but you still have a 404. Still going on the example from #52, assume the id
param is indeed numeric but the id isn't found in the database. You still need to redirect to the 404 in that case. So it weakens the argument for param validation based on regex IMO.
from react-router.
Ignoring #52 (since it has been solved quite nicely with https://github.com/bjyoungblood/rnr-constrained-route) I still wonder if there's some interesting stuff we just aren't thinking about yet that could happen if people could make their own <Route>
.
But until we have a strong use-case that can't be solved elegantly with the existing api, happy to leave this sitting here and pick it up then.
from react-router.
@rpflorence Can you post an example how this could solve the context problem discussed in #57?
from react-router.
var ContextualRoute = React.createClass({
mixins: [ Router.RouteMixin ],
getDefaultProps: function() {
return { context: { foo: 'bar' } }
}
});
<ContextualRoute handler={App}/>
<!-- instead of -->
<Route context={context} handler={App}/>
from react-router.
I don't think we need to do anything fancy here anymore, the way we've implemented <Redirect/>
shows that making custom route config components is trivial. https://github.com/rackt/react-router/blob/master/modules/components/Redirect.js
Unless @spicyj sees something terrible about treating a plain old function like a component ... I felt a little sneaky when I wrote that code.
from react-router.
Actually, yes. Plain functions will soon cease to work in JSX because of a handful of changes we're planning to make soon – you'll hear more details from @sebmarkbage when they're ready.
from react-router.
Would like to know how to accomplish what we have with Redirect
so we can change the implementation before those changes break it.
from react-router.
Related Issues (20)
- [Docs]: Tutorial missing imports within 'contacts.js'. [ "match-sorter" , "localforage" , "sort-by" ] HOT 1
- [Bug]: history.listen not triggered on hash changes HOT 1
- [Bug]: Update comments recommending to use polyfill.io HOT 3
- [Docs]: Nested Routes are essentially undocumented HOT 5
- [Bug]: unstable_patchRoutesOnMiss is superseded by "*" (404) HOT 3
- [Bug]: unstable_patchRoutesOnMiss leaf ignored when patching sub-trees asyncronously HOT 3
- [Bug]: Functional updates to `useSearchParams` don't get updated values HOT 2
- Update to isbot@5 HOT 1
- [Bug]: `unstable_patchRoutesOnMiss` remote module error-handling HOT 13
- [Bug]: useMatch does not decode params HOT 4
- [Bug]: Could not resolve './utils' from packages/router/index.ts HOT 2
- [Bug]: Link when used with Outlet is not working. It is routing to error page when clicked. HOT 1
- [Bug]: setSearchParams from useSearchParams remove hash HOT 1
- [Bug]: HashRouter need to wrapped twice HOT 1
- [Docs]: docs show reach/router instead of react/router HOT 2
- [Bug]: "react-router-dom-v5-compat" <CompatRouter> doesn't unsubscribe from history potentially causing tests to memory leak HOT 2
- [Bug]: child loader redirect overrides parent loader error HOT 7
- [Bug]: v7_partialHydration with unstable_patchRoutesOnMiss: hydrateFallbackElement not shown on patched routes HOT 3
- [Bug]: Relative path does not work as expected in outlets HOT 1
- [Bug]: useNavigate causes component to rerender HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-router.