Giter Site home page Giter Site logo

Better root route docs about react-router HOT 4 CLOSED

remix-run avatar remix-run commented on March 28, 2024
Better root route docs

from react-router.

Comments (4)

jasonkuhrt avatar jasonkuhrt commented on March 28, 2024

This does not work.

Whoops, Sorry for the ambiguity. What I meant here is intro is never rendered AKA just a blank screen.

from react-router.

ryanflorence avatar ryanflorence commented on March 28, 2024

You can't redirect from root, that's an infinite loop because root always renders. If you are at any route, you are also at the root route.

You want a mixin that does this redirect for any protected routes.

Sent from my iPhone

On Jul 8, 2014, at 10:00 PM, Jason Kuhrt [email protected] wrote:

I ran into some confusing behaviour that I would appreciate explained and documented better. In my root Route:

var routes = Route({ handler: z },
Route({ name: 'intro', handler: viewIntro }),
Route({ name: 'dashboard', handler: viewDashboard }),

z does this:

var z = React.createClass({
displayName: 'z',
statics: {
willTransitionTo: function(transition){
if (user_used_app_count() === 1) {
transition.redirect('intro')
}
}
},
render: function(){
This does not work.

I got it working by not redirecting on root:

var viewDashboard = React.createClass({
displayName: 'dashboard',
statics: {
willTransitionTo: function(transition){
if (user_used_app_count() === 1) {
transition.redirect('/intro')
}
}
},
render: function(){
Clarity about what's going on would be greatly appreciated.


Reply to this email directly or view it on GitHub.

from react-router.

jasonkuhrt avatar jasonkuhrt commented on March 28, 2024

@rpflorence Makes sense, just silently fails though. To what degree this only happens in the first 10 minutes of trying RNR I don't know but maybe its something we can detect and fail explicitly on.

from react-router.

jasonkuhrt avatar jasonkuhrt commented on March 28, 2024

@rpflorence Ok the issue causing this was #76 (comment)

Silly stuff.

from react-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.