remix spa mode cannot with `` , when run `npm run preivew`, it's a empty page

[zouhangwithsweet]

remix spa mode cannot with `[email protected]` , when run `npm run preivew`, it's a empty page

[brophdawg11]

yeah this seems to be a bug in rollup 4.16 when it comes to function parameters with default values.

Our flattenRoutes function is defined as:

function flattenRoutes<
  RouteObjectType extends AgnosticRouteObject = AgnosticRouteObject
>(
  routes: RouteObjectType[],
  branches: RouteBranch<RouteObjectType>[] = [],
  parentsMeta: RouteMeta<RouteObjectType>[] = [],
  parentPath = ""
): RouteBranch<RouteObjectType>[] {
  ...
}

And it gets transpiled down differently in rollup 4.15 versus 4.16, with 4.16 incorrectly blowing away the branches parameter value on every invocation:

// rollup 4.15
function flattenRoutes(routes, branches, parentsMeta, parentPath) {
  if (branches === void 0) {
    branches = [];  // ✅ Only sets the default if no value is passed
  }
  if (parentsMeta === void 0) {
    parentsMeta = [];
  }
  if (parentPath === void 0) {
    parentPath = "";
  }
  // ...
}

// rollup 4.16
function flattenRoutes(routes, branches, parentsMeta, parentPath) {
  {
    branches = []; // ❌ Lost the if statement, so it sets the default every time
  }
  if (parentsMeta === void 0) {
    parentsMeta = [];
  }
  if (parentPath === void 0) {
    parentPath = "";
  }
  // ...
}

[brophdawg11]

This should be resolved in rollup 4.16.2: https://github.com/rollup/rollup/releases/tag/v4.16.2

[huijiewei]

override rollup to 4.15.0, this is rollup issue.

[brophdawg11]

For now the proper workaround is to install [email protected], or set it in the overrides section of your package.json:

"overrides": {
    "rollup": "4.15.0"
}