renehamburger/blinx.js

A multi-language client-side script to automatically convert Bible references to Bible links with a passage pop-up

blinx.js's Issues

False positives

In the string 'Josua, Richter, 1. und 2. Samuel und 1. und 2. Könige', both 'Richter, 1' and 'Samuel und 1' are wrongly interpreted as references.

Provide transformation to handle German terms not recognised by the parser yet

The terms defined in de/data.txt contain only some of the case-number variations possible. For example, $VERSE Verse Vers. Ver. Vs. should also include 'Versen' (e.g., 'in den Versen 3-4').

Add bx-passage attribute to manually provide the correct passage for a text

Improve handling of chapter-less contexts

There are two issues with the current implementation, which can be seen in

blinx.js/src/blinx.class.spec.ts

Lines 241 to 261 in 72d8184

	it('works for reference without chapter (initial implementation)', async () => {
	await testRecognition(
	`<p data-bx-context="Matt">
	Check out verse 9 and then 6:10 (cf. Luke 11:2)
	and verse 11.
	</p>`,
	['verse 9', '6:10', 'Luke 11:2', 'verse 11'],
	['Matt.1.9', 'Matt.6.10', 'Luke.11.2', 'Matt.1.11']
	);
	});
	xit('works for reference without chapter (final implementation)', async () => {
	await testRecognition(
	`<p data-bx-context="Matt">
	Check out verse 9 and then 6:10 (cf. Luke 11:2)
	and verse 11.
	</p>`,
	['6:10', 'Luke 11:2', 'verse 11'],
	['Matt.6.10', 'Luke.11.2', 'Matt.6.11']
	);
	});

As the given context does not contain a chapter:

• chapter-less references within the section should take their chapter from any previously recognised passage in that section (rather than the chapter 1 supplied to the chapter-less context to allow parsing)
• if a chapter-less reference has no preceding recognised passage, it should be skipped

Improve parsing of German references

• Add more common book abbreviations

Implement internationalisation (i18n)

Improvements to handling of partial references

Partial references should not trump later complete references

In the following text, the second partial reference takes its context not from the preceeding (complete) reference, but the partial one before that:

Verse 14–15 (vgl. 2. Mose 20,1–3) ... in den Versen 16–20?

(EDIT: This was probably due to a provided context, so works as expected.)

This seems to be the opposite problem of the previous: Partial references with contexts should also be used to provide the context for following partial references:

In <bx context="Rev 21">verse 3</bx> (similar to 1 Peter 1:4) and in verse 4...

Introduce bx-aside

A very common scenario is a longer section about one passage, which has brief references to other books or chapters, e.g. in brackets. At the moment, each one of them changes the context for the following partial references. It would be great to be able to create a separate parsing-context with a tag like <bx-aside> (or even just <bx>) to prevent those references from changing the context for the following partial references.

Exclude tags that can only contain text-nodes

Certain fields (<input>, <textarea> , <pre>? ...) cannot take html nodes, so they need to always be excluded.

Recognising pure chapter numbers

The chapter 35 in the German Bible reference "Jesaja 11,1–9; 35" is not recognised. Is this a limitation of the parser?

GetBible-API Update to v2

Wie in der Readme von GetBible aufgelistet, wird der alte API-Aufruf nicht mehr unterstützt, sollte eigentlich schon Ende 2021 abgeschalten werden.

Jetzt sollte man den Pfad über /v2 aufrufen.

https://github.com/getbible/v2

We will keep the old API (the current URL query option on getBible.net) active for another year, ending 2021. We therefore encourage you all to upgrade to the newer, better option, explained below, as soon as you can.

We will always have a Version one (V1) and a Version two ([V2](https://github.com/getbible/v2)) as long as the Lord permits. V1 will return the Holy Scripture in the same format as the original (old API) but with a whole new URL query format, which we will explain in details below. [V2](https://github.com/getbible/v2) will serve as the new format being introduced to solve common issues and provide a better, faster, stronger, more accurate, and convenient API of the Holy Scripture.
How will this work?

The old API query looked like this:

    https://getbible.net/json?passage=1Jn3

The new API (V1) query will look like this:

    https://getbible.net/v1/kjv/62/3.json

    That is really the only change, but we trust it will serve us all better.

[V2](https://github.com/getbible/v2) query will look like this:

    https://getbible.net/v2/kjv/62/3.json

Allow pure books as content of bx-context

Tippy popover sometimes not shown on IE9-11

This seems to be a race condition, which is most prevalent during local development and on http://localhost:9000/fixtures/API-test.html.

Wrong versification used for Schlachter 1951 by getBibel API

Versifications differ between most German and English Bibles in several places. For example, Mal 3,19-24 in German Bibles corresponds to Mal 4:1-6 in English Bibles.

See "TVTMS - Tyndale Versification Traditions with Methodology for Standardisation" at STEPBible-Data for extensive details on versification differences.

Why is the Text Schlachter and the link ELB on the demos?

Is that due to copyright issues? Also on the one demo the link to the getbible api is broken points to here: https://getbible.net/v2/

Thanks for that library looking forward to integrate it.

Implement parsing of multiple partial references in a text node

Implement simple caching

To start with, just store retrieved passages in API classes for a second hover on the same link. Optionally in localStorage, but then it needs to be possible to invalidate it.

A manual execution of `blinx.execute()` can fail if the parser script has not been loaded yet

As they can lead to the script

Add infinite scroll for larger passages

Requests to GetBible V2 API fail due to CORS issue

Upon loading blinx.js the request to the getbible checksum API fails with the following CORS error (Chrome):

Access to XMLHttpRequest at 'https://getbible.net/v2/checksum.json?v=1695667014779' from origin 'https://www.evangelium21.net' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

I assume this error was introduced with the migration to the V2 API.

Strangely when I load the checksum API directly in the Browser I can see that it does indeed respond with a Access-Control-Allow-Origin: * header.

First verse of single-chapter books not recognised

Jud 1 or 3Joh 1 are not recognised, Jud 2 or 3Joh 2 etc. are working fine.

Support Soft Hyphens

If the book name of a bible reference contains soft hyphens (­ or ­) it is not recognized.

Example (HTML):
Ze­phan­iah 3:17

Implement cross-chapter requests via getBible

Passages like Lk 1:5–2:52 are not currently recognised by the getBible API. The need to be split into two references: 'Lk 1:5-999; Lk 2:1-52'.

Verse-ranges should not be combined across Psalms or books

"Psalm 96:10–13; 97:1" should not be combined to "Psalm 96:10-97:1" and "Matt 26-28; Mark 1" not to "Matt 26-Mark 1".

BTW, why is Matt 1-28 not recognised?

Tests on IE10 unstable

There seems to be a timing issue/race condition, which sometimes leads to the links not being created.