Comments (6)
Update: for more clarity on my suggestion, I've forked the repo and made the structural changes I suggested. NB! The README and other root-level files (e.g., Pipfile
, test.py
) have been either significantly modified or removed altogether. If the above assumptions I made were valid, I can put these changes in a separate pull request so that your project-level files remain unaltered.
from reolinkapipy.
HI @barretobrock thank you for using the library, really appreciate your input. I will look into refactoring the library as you have mentioned, but I will need to hold back on that for a bit since it will introduce some breaking changes if someone is using the library straight from GitHub. So I'll do this once I've sorted some other changes I want to make and then bump the version to v0.1.0.
from reolinkapipy.
Sounds good. Happy to help either way.
from reolinkapipy.
that would be great, I wanted to remove the openCV dependency before doing that, but it seems I can't find a proper RTSP client implementation in python3. So it's been taking longer than expected. I suppose, let's just do the refactor and then I'll get rid of the dependency at a later stage. I'm open for a PR if you're willing 👍
from reolinkapipy.
Yep, I can likely submit a PR this weekend.
Regarding RTSP clients, I have limited experience with them, but in the ~2 implementations I've seen the package provider will simply provide an easy way for the user to obtain the RTSP url or stream and then let the user make the decision about what client they want. Here's an example of that from Amcrest's package. I think if you decided to go this route, you could include in the examples a use case for using openCV without having to include it in the requirements. Anyway, just my 2 cents.
from reolinkapipy.
That would be great 👍
Yeah in the current release I updated it to only return the image stream (using cv2) with an example of how to view the stream using cv2 (here). So the plan is just to replace the cv2 dependency with a smaller alternative and keep the example as is - meaning the return data will be the same. I have found some RTSP clients that do return a raw stream, but it would need a bit of work for it to be considered stable enough to include in this library. I have done something similar in the Go library, but it actually had a proper library to work from.
from reolinkapipy.
Related Issues (20)
- ImageApi has no example response HOT 3
- Help: List of suppported Camera's HOT 17
- Error while decoding MB HOT 3
- Get_snap error HOT 2
- Download files issue HOT 2
- Make image processing dependencies optional HOT 1
- Possibility of reading an alert detection for A series. HOT 5
- Start Recording/Alarm manually - List of Python Commands HOT 2
- Adding support to reolink go camera HOT 2
- Set enable or disable push / email notifications HOT 1
- snap image returns empty despite IP ping working HOT 2
- requirements.txt is empty HOT 3
- login error - is RLC-510a supported? HOT 6
- get_snap incorrectly references random library HOT 3
- Get Alarm Motion not working HOT 1
- Get_snap and Open_video_stream not working HOT 2
- Controlling the camera remotely HOT 1
- I added the ability to update the certificate HOT 1
- Reolink API documentation HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reolinkapipy.