Giter Site home page Giter Site logo

Comments (3)

repodiac avatar repodiac commented on May 25, 2024

I can see your point, however I would like to reproduce (see PR comments) to check the exact behaviour for myself. If you have another compound where it gives an "index out of range" error, please provide :)

from german_compound_splitter.

sebag90 avatar sebag90 commented on May 25, 2024

I'm sorry, I tried again and I notice that I made a mistake, try "pflanzenart" all lowercase, for me it breaks the code at line 248. This is not the case for other compounds such as "Autobahn"/"autobahn", "Straßenreinigung"/"straßenreinigung", "tierart"/"Tierart".
Let me know if that works :)

from german_compound_splitter.

repodiac avatar repodiac commented on May 25, 2024

Got it. Thank you, I used quite some time to get to the core of the issue - your fix did prevent the Index Out Of Range error, but had rather some other side effects. It was not intended to allow for lowercase compound words, thus I used a different approach. I just changed the first letter to uppercase, thus the behaviour is rather as expected now.

Thank you for filing the issue and pointing out! I also added some other improvements for handling plural, btw. There is a new release 0.1.1now. I thus will close the PR.

from german_compound_splitter.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.