Giter Site home page Giter Site logo

Comments (35)

rougier avatar rougier commented on June 18, 2024 1

I think we're waiting for @vahtras review (gentle pressure :) )

from submissions.

rougier avatar rougier commented on June 18, 2024

Thanks for your (late) submission :) We'll assign an editor soon.

@pdebuyl Can you handle this submission (Physics/Python/Fortran) for the Ten Years Reproducibility Challenge (only # reviewer needed) ?

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

As editor thus?

from submissions.

rougier avatar rougier commented on June 18, 2024

@pdebuyl Yes, sorry, I should have explained.

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

ok

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

I mean, "I will edit" :-)

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

@jochym could you review the submission here? If this is your first review for ReScience, I will guide you through the process.

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

@dombrno could you review the submission here? If this is your first review for ReScience, I will guide you through the process.

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

@vahtras will review the paper. Thank you Olav!

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

ping @vahtras

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

@berquist would you review the submission "fermions at unitarity" for ReScience ? If this is your first review for ReScience, I will guide you through the process.

from submissions.

vahtras avatar vahtras commented on June 18, 2024

Is there a howto for reviewers @pdebuyl ?

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

Hi @vahtras

We have reviewer guidelines here: https://rescience.github.io/edit/

The most specific part of the review, in relation to ReScience, is to actually run the code and verify the claims of reproduction that are stated in the article.

Specifically for the ten-year challenge

  • We only require one reviewer.
  • The requirement to have a readable and reusable code are relaxed a bit. It would make little sense for the authors of this issue to perform a full modernization of their code.
  • The author should provide in the article their reflection on the longevity, quality and retrievable character of their old code and of the corresponding environment (language, platform-specific code, proprietary tools, etc).

from submissions.

ev-br avatar ev-br commented on June 18, 2024

In this specific case, rerunning the full set of calculations might not be very practical, since it's going to require a non-negligible cpu time on a cluster.
Not sure what are implications though.

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

How many core-hours ? (or core-days / node-days depending on the hardware you have used)?

from submissions.

ev-br avatar ev-br commented on June 18, 2024

The largest runs in the supplement repository are some 120 CPU hours on 24 cores. Multiply it by about 1.5-2 for thermalization.
Smaller system sizes are much faster, some 4-10 cpu hours each, if a partial verification is OK. (rerun small system sizes on the reviewer's machine, rerun the fits with a mix of reviewer's data and my data or somesuch).

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

Well, this seems indeed costly. @vahtras do you have the resources for the small systems verification? (4-10 cpu hours each) ? I could execute that if necessary.

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

Hi all,

I see only now that the review process is frozen here. @vahtras what do you think of the computational requirements?

from submissions.

vahtras avatar vahtras commented on June 18, 2024

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

Hi @vahtras thank you for getting back to us :-) Other papers are still in the pipeline, so this should be ok.

from submissions.

ev-br avatar ev-br commented on June 18, 2024

Anything needed from me at this stage?

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

@vahtras do you still plan to review the article?

from submissions.

vahtras avatar vahtras commented on June 18, 2024

Yes, finally. First question: the makefile has been hardcoded for Intel compilers. Does it build with GNU?

from submissions.

ev-br avatar ev-br commented on June 18, 2024

It certainly does. ev-br/10yr_repro_challenge_35@837038f is the relevant makefile.

I then simply commented it out when transferring to cluster/intel compiler instead of adding platform detection (more brittle stuff to debug ten years down the line)

The change from gnu on a laptop to intel on cluster is here:
ev-br/10yr_repro_challenge_35@3603020

EDIT:the switch from gnu to intel is
ev-br/10yr_repro_challenge_35@acc2974

from submissions.

rougier avatar rougier commented on June 18, 2024

@pdebuyl Any progress?

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

Hi @rougier sorry about this. @vahtras is this still doable for you? In the meantime, I will try to find another reviewer.

from submissions.

vahtras avatar vahtras commented on June 18, 2024

from submissions.

rougier avatar rougier commented on June 18, 2024

@pdebuyl I think you need to find a new reviewer. You can use the @ ReScience/reviewers notification if necessary.

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

@rougier I have started to do so.

from submissions.

rougier avatar rougier commented on June 18, 2024

Good. Any progress?

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

Yes, I have a candidate reviewer but am waiting for confirmation before putting it here.

from submissions.

rougier avatar rougier commented on June 18, 2024

Gentle reminder

from submissions.

pdebuyl avatar pdebuyl commented on June 18, 2024

Hi @rougier unfortunately I "lost" my candidate reviewer. In all fairness (and despite the already long delay), I'd prefer to wait mid-august to look again the mid-summer is a really bad time to find reviewers!

PS: I'll also consider reviewing the paper and have Konrad or someone else be editor (august as well I am not in office)

from submissions.

rougier avatar rougier commented on June 18, 2024

Ok. Note that according to our process, you can serve as 2nd reviewer while being the editor.

from submissions.

rougier avatar rougier commented on June 18, 2024

Any progress?

from submissions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.