Remove `stopping` and the entire `KeepRunning` construct

[restioson]

Remove `stopping` and the entire `KeepRunning` construct

[Restioson]

This does make sense to me, I think. I really like how this simplifies control flow and general usage - less ways to do the same thing. You can emulate preventing an actor from shutdown from Actor::stopping by adding a ShutdownMaybe message which then checks if the actor should be shut down, and calls Context::stop if required.

[Restioson]

This would supercede and close #58, right?

[thomaseizinger]

This would supercede and close #58, right?

Yes.

[thomaseizinger]

This does make sense to me, I think. I really like how this simplifies control flow and general usage - less ways to do the same thing. You can emulate preventing an actor from shutdown from Actor::stopping by adding a ShutdownMaybe message which then checks if the actor should be shut down, and calls Context::stop if required.

Yep, I had a similar thought. I think moving more of this functionality into messages is a good thing.

I've also been contemplating the idea of making the started lifecycle hook a message but I am not fully sure about that yet :)

[Restioson]

How would replacing started work? Would each address of the actor be made to send a start message?

[thomaseizinger]

I was thinking of something like this (assuming #62):

impl Context {
	pub async fn run<A>(mut self, actor: A) -> A::Stop where A: Actor + Handler<Started, ()> {
		self.address.send(Started).await;
	}
}

But I just realized that that doesn't work because we obviously can't receive messages until we are in the actual loop within the context.

[thomaseizinger]

This does make sense to me, I think. I really like how this simplifies control flow and general usage - less ways to do the same thing. You can emulate preventing an actor from shutdown from Actor::stopping by adding a ShutdownMaybe message which then checks if the actor should be shut down, and calls Context::stop if required.

Cool. If you are on-board with that, I will have a go at removing the function and all the code associated with KeepRunning etc.

[Restioson]

Sure, and thanks! 👍

[Restioson]

Solved by #82 . Note that KeepRunning was kept for attach_stream but when this is moved to an extension crate it will go there too.