Golang semgrep rule not matching every method invocation inside method body

[shivasurya]

Golang semgrep rule not matching every method invocation inside method body

[ievans]

hi @shivasurya , this is actually expected behavior as $X.Verify() is a statement when written in the body of a function like that, and you are looking for it in an expression context. If you only wanted to match what you have I'd write two separate patterns, e.g.: https://semgrep.dev/playground/s/5rvrl

    patterns:
      - pattern: $X.Verify()
      - pattern-inside: |
          func $RESOLVER() { 
              ...
          }

Or if you just want inside the if blocks, you could use the deep expression operator: https://semgrep.dev/docs/writing-rules/pattern-syntax/#deep-expression-operator

func $RESOLVER() {
  ...
  if <... $X.Verify() ...> {
    ...
  }
  ...
}

I'll close this issue but would welcome ideas on how we can make this behavior more intuitive!

[shivasurya]

Thanks @ievans for the quick feedback. I'm not sure if this will cover all cases in the code within function block. However, I'll try to workaround with this.