Giter Site home page Giter Site logo

Comments (5)

scottf-tvw avatar scottf-tvw commented on August 24, 2024 2

Something else to note, even if you close this with a flag the pipe may still have data enroute.
You will need to be sure that the BufferedDuplex class in the _write method does not try to write to a closed passthrough.
src/models/streaming/BufferDuplex.ts line 23

This will solve this issue

public _write(chunk: any, encoding: string, callback: any): boolean {
        if (this.input.writable){
            return this.input.write(chunk, encoding, callback);
        }
}

probably have to return false too if it's not true?

from revai-node-sdk.

kbridbur avatar kbridbur commented on August 24, 2024 1

Thanks for filing the issue. We're working on a fix here: #61

from revai-node-sdk.

scottf-tvw avatar scottf-tvw commented on August 24, 2024

I can confirm this issue as well. @srubin did you test that possible fix? This is important issue blocking when using ffmpeg piped to the stream duplex. especially when trying to avoid the 2hr limit while switching socket sessions and reassigning the pipe to the new duplex.

from revai-node-sdk.

srubin avatar srubin commented on August 24, 2024

Confirmed that it is fixed in 2.6.1

from revai-node-sdk.

amikofalvy avatar amikofalvy commented on August 24, 2024

@scottf-tvw We are looking into your comment separately.

from revai-node-sdk.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.