Comments (7)
I'm not that experienced in dealing with Dune, so I'd be happy to leave this up to someone else if we'd like to go for https://github.com/anuragsoni/color :)
from revery.
This is a good place to start looking: https://github.com/bryphe/revery/blob/master/src/Core/Color.re
from revery.
Sounds like @kitten might help us out here! 💯
from revery.
What do you think about factoring out Color
to be universal to some extent?
There are https://opam.ocaml.org/packages/gg/ and https://opam.ocaml.org/packages/color/, and I've been considering to base some solution off of it for Brisk. Your implementation is as close as I'd imagine it myself.
from revery.
What do you think about factoring out Color to be universal to some extent?
Would be open to it, if it'd be useful!
There are https://opam.ocaml.org/packages/gg/ and https://opam.ocaml.org/packages/color/, and I've been considering to base some solution off of it for Brisk.
Cool. I didn't know about https://opam.ocaml.org/packages/color/ - that looks like exactly what we need for parsing / hex conversion. The only other thing we really have beyond that here is our list of colors contributed by @bgoscinski : https://github.com/bryphe/revery/blob/master/src/Core/Colors.re - is that something that would be useful for Brisk?
from revery.
Sure, why not. I wonder if they could be upstreamed into Color
or Gg
, otherwise, we'd end up repeating it everywhere.
from revery.
I went ahead and added the @opam/color
lib 👍 (And exposed just a thin wrapper that basically shifts the API from snake case to camel case).
@rauanmayemir - @jchavarri had an idea that is relevant to the sharing out of these sorts of APIs. He drafted a proposal here: revery-ui/reason-reactify#35
I think it's a really cool idea - having some set of basic primitives that could be used between projects. Wouldn't it be neat if you could create a custom component that could be used in both revery
and brisk
, for example? Would be great to get your feedback on that issue!
from revery.
Related Issues (20)
- Ubuntu 20.10: revery-ui/esy-skia build failed HOT 3
- Ubuntu 18.10 / 19.04: @opam/ocamlfind@opam:1.8.1 build failed HOT 5
- esy '@examples' run output has no text (Revery.FontCache: Error loading typeface (skia)) HOT 4
- Uncaught Division_by_zero crash on window resize. (maxHeight vs flexGrow ?) HOT 1
- Revery roadmap in face of Reason->Rescript rebrand HOT 2
- Having problem with building revery-quick-start project on Mac HOT 7
- MacOS: Allow selective modifier key mapping
- esy install failing on Windows. HOT 3
- Build Revery is presenting failure in shell.c HOT 2
- ScrollView does not work if children are added after initial mount
- CI: esy-skia won't build on Linux HOT 1
- createWindow with visible=false does not create a hidden window HOT 3
- Update the build guide for Fedora HOT 4
- SVG drawing mangled if OS locale does use a different floating point presentation HOT 4
- Quickstart build step error HOT 1
- Windows10 esy is installed but revery-ui can not be installed
- Build revery with esy on mac failed HOT 9
- Can't build on Fedora 35 due to glibc bug HOT 4
- OCaml <=14.12 doesn't support glibc>=2.34 HOT 9
- Support for FreeBSD HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from revery.