Giter Site home page Giter Site logo

Comments (7)

kitten avatar kitten commented on April 30, 2024 1

I'm not that experienced in dealing with Dune, so I'd be happy to leave this up to someone else if we'd like to go for https://github.com/anuragsoni/color :)

from revery.

bryphe avatar bryphe commented on April 30, 2024

This is a good place to start looking: https://github.com/bryphe/revery/blob/master/src/Core/Color.re

from revery.

bryphe avatar bryphe commented on April 30, 2024

Sounds like @kitten might help us out here! 💯

from revery.

rauanmayemir avatar rauanmayemir commented on April 30, 2024

What do you think about factoring out Color to be universal to some extent?

There are https://opam.ocaml.org/packages/gg/ and https://opam.ocaml.org/packages/color/, and I've been considering to base some solution off of it for Brisk. Your implementation is as close as I'd imagine it myself.

from revery.

bryphe avatar bryphe commented on April 30, 2024

What do you think about factoring out Color to be universal to some extent?

Would be open to it, if it'd be useful!

There are https://opam.ocaml.org/packages/gg/ and https://opam.ocaml.org/packages/color/, and I've been considering to base some solution off of it for Brisk.

Cool. I didn't know about https://opam.ocaml.org/packages/color/ - that looks like exactly what we need for parsing / hex conversion. The only other thing we really have beyond that here is our list of colors contributed by @bgoscinski : https://github.com/bryphe/revery/blob/master/src/Core/Colors.re - is that something that would be useful for Brisk?

from revery.

rauanmayemir avatar rauanmayemir commented on April 30, 2024

Sure, why not. I wonder if they could be upstreamed into Color or Gg, otherwise, we'd end up repeating it everywhere.

from revery.

bryphe avatar bryphe commented on April 30, 2024

I went ahead and added the @opam/color lib 👍 (And exposed just a thin wrapper that basically shifts the API from snake case to camel case).

@rauanmayemir - @jchavarri had an idea that is relevant to the sharing out of these sorts of APIs. He drafted a proposal here: revery-ui/reason-reactify#35

I think it's a really cool idea - having some set of basic primitives that could be used between projects. Wouldn't it be neat if you could create a custom component that could be used in both revery and brisk, for example? Would be great to get your feedback on that issue!

from revery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.