Framebuffer and window size aren't matching

[revery-ui]

Framebuffer and window size aren't matching

[manu-unter]

I just had a similar artifact when trying out the Bin example:

One thing that caught my eye is the fact that the actual content only occupies the lower left quarter of the window, both for me and for @jordwalke.

To me, this looks a lot like a scaling issue where the two dimensions are off by a factor of 2 exactly. Maybe even this has something to do with layout pixels vs native pixels, i.e. what we would call devicePixelRatio on the web? I know for a fact that my devicePixelRatio is exactly 2.

I am not familiar enough yet with the way we create the window and scale the content, but I might be able to take a look into it once I took a deep dive through the whole thing. I'll have to do that anyway to figure out how to implement our texture atlas :)

[bryphe]

To me, this looks a lot like a scaling issue where the two dimensions are off by a factor of 2 exactly. Maybe even this has something to do with layout pixels vs native pixels, i.e. what we would call devicePixelRatio on the web? I know for a fact that my devicePixelRatio is exactly 2.

Yes, I think this is definitely the issue! I added some code to handle this (the difference in 'screen size' and 'pixel size' in PR #66 ).

I believe that PR addresses this - but I don't have an environment where this reproduces (my Surfacebook has a high DPI, but the screen size == pixel size, so I don't hit this issue on it). Would be interested to see if it is fixed w/ latest master.

I am not familiar enough yet with the way we create the window and scale the content, but I might be able to take a look into it once I took a deep dive through the whole thing. I'll have to do that anyway to figure out how to implement our texture atlas :)

I hope that PR #66 helps give some ideas! But of course, let me know if you have any questions 😄 I could definitely use your WebGL skills - the text rendering here is so limited compared to what you implemented for Oni's renderer.

[manu-unter]

Wow, that was quick 🐎

I just tested on the newest master and didn't have the issue anymore:

Thanks for fixing! I guess you can close the issue now ✌️

[bryphe]

Sweet, thanks for confirming the fix @Cryza ! 💯