Rotation doesn't update for <view>s

[revery-ui]

Rotation doesn't update for s

from revery.

[bryphe]

Hey @OhadRau ! Thanks a lot for trying it out 😄 And for providing the minimal repro - very helpful.

Just tested it, and it's indeed a bug - we weren't updating the 'ViewNode' in our scene graph when the style changes. Pushed up a fix in #74

(Btw thanks for this project, I've been waiting for something like this to come along for ages... would love to help out on some of the work for this library)

That would be great, I could definitely use help! Let me know if there is a particular aspect you're interested in or if you need any help getting going.

[OhadRau]

Awesome, thank you for the quick fix :) I was just messing around making some of the demos with open issues to get to know the library for now (I have a working wall clock @ https://github.com/OhadRau/revery/blob/master/examples/Clock.re but it's implemented super weirdly since rotations always anchor at the center). I'd be happy to try adding some features though, I might try to tackle anchor points with a PR (although idk what kind of API you'd want to have for that).

[bryphe]

@OhadRau - that clock is really cool! I just tried it out and was playing around with it 👍 Exactly the kind of example we need. Please feel free to submit it via a PR.

but it's implemented super weirdly since rotations always anchor at the center)

Oh ya, this is the default, but it can actually be changed with a transform:

transform=[RotateZ(Angle.from_degrees(90.), TranslateY(50.)]

This means - first move the element up 50 pixels, then apply the transform from the original center.

The order of operations is important, too, since:

transform=[TranslateY(50.), RotateZ(Angle.from_degrees(90)]

would mean rotate first from the center, and then apply the transform.

I think this would allow for anchor points (similar discussion here for react native: https://stackoverflow.com/questions/37165715/react-native-transforms-with-pivot-point)

One possibility would be to have a convenience method like rotateWithPivot: (Angle.t, Vec2.t) => list(Transform.t) = (angle: Angle.t, anchorPoint: Vec2.t) => { ... } that could help provider a higher-level abstraction for this construction.