Comments (5)
HI, action-rubocop already has the suggestion feature since v2.0.0. Why don't you try it?
ref #28
from action-rubocop.
HI, action-rubocop already has the suggestion feature since v2.0.0. Why don't you try it?
ref #28
Yes, this looks like what I want. It looks like the solution is to combine this repo with https://github.com/reviewdog/action-suggester. Where is the documentation for how to enable that? I looked in the readme and also generally searched this repo and I didn't get any hits, besides this issue and your linked issue.
from action-rubocop.
You don't have to enable the feature, it automatically works by default.
If your GitHub Action doesn't suggest anything, there would be possibilities below.
- You're using
action-rubocop@v1
- Your offenses are not correctable by rubocop. As you may know, rubocop can't correct all offenses.
from action-rubocop.
Okay, thanks, I set it up following https://docs.github.com/en/actions/quickstart & the example config from the readme. So I think this issue can be closed, thanks for the help!
As an aside, I found the setup process to be fairly confusing
- no "suggestion" example in the readme
- readme screenshots show other config modes, but not suggestion mode
- the marketplace listing is really unclear what is the right version to expect:
from action-rubocop.
Oh, I realized that's the reason why some people still start using action-rubocop@v1
...! Thanks for the info.
Regarding the marketplace issue, I'll continue on #74.
from action-rubocop.
Related Issues (20)
- Add ability to skip install of rubocop and extensions HOT 1
- How i can use my own robocop rule? HOT 1
- Set default token to `github_token` input parameter HOT 5
- Undefined method `begin' for PseudoSourceRange HOT 6
- Fail running rubocop step if rubocop command itself fails HOT 5
- gem install was failed with Ruby 2.6.6 HOT 2
- Getting undefined method `cleanpath` when running via GitHub HOT 6
- Takes too long HOT 5
- getting REVIEWDOG_GITHUB_API_TOKEN error HOT 2
- [BUG] Invalid request. Only 65535 characters are allowed; 70292 were supplied. HOT 6
- undefined method `begin' for nil:NilClass HOT 2
- GitHub marketplace shows v1 as the latest HOT 2
- Rubocop info severity causes build failure
- reviewdog fails to parse when `--server` option is given HOT 1
- `Style/MethodDefParentheses` creates a suggestion with just one opening parenthese
- Cache ruby gems to speed up installation HOT 2
- Replace actions/create-release HOT 1
- rubocop_extensions installation version from Gemfile does not work with wrong definition order of gems HOT 5
- The suggedtion for `Rails/RedundantActiveRecordAllMethod` is incorrect
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action-rubocop.