Giter Site home page Giter Site logo

Comments (5)

ohbarye avatar ohbarye commented on August 18, 2024

HI, action-rubocop already has the suggestion feature since v2.0.0. Why don't you try it?

ref #28

from action-rubocop.

aharpervc avatar aharpervc commented on August 18, 2024

HI, action-rubocop already has the suggestion feature since v2.0.0. Why don't you try it?

ref #28

Yes, this looks like what I want. It looks like the solution is to combine this repo with https://github.com/reviewdog/action-suggester. Where is the documentation for how to enable that? I looked in the readme and also generally searched this repo and I didn't get any hits, besides this issue and your linked issue.

from action-rubocop.

ohbarye avatar ohbarye commented on August 18, 2024

You don't have to enable the feature, it automatically works by default.
If your GitHub Action doesn't suggest anything, there would be possibilities below.

  • You're using action-rubocop@v1
  • Your offenses are not correctable by rubocop. As you may know, rubocop can't correct all offenses.

from action-rubocop.

aharpervc avatar aharpervc commented on August 18, 2024

Okay, thanks, I set it up following https://docs.github.com/en/actions/quickstart & the example config from the readme. So I think this issue can be closed, thanks for the help!


As an aside, I found the setup process to be fairly confusing

  • no "suggestion" example in the readme
  • readme screenshots show other config modes, but not suggestion mode
  • the marketplace listing is really unclear what is the right version to expect:

image

- clicking the "use latest version" button shows this screen which basically gives me no instruction on what to actually do (might be GitHub's problem not yours...):

from action-rubocop.

ohbarye avatar ohbarye commented on August 18, 2024

Oh, I realized that's the reason why some people still start using action-rubocop@v1...! Thanks for the info.
Regarding the marketplace issue, I'll continue on #74.

from action-rubocop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.