Giter Site home page Giter Site logo

Comments (11)

haya14busa avatar haya14busa commented on June 6, 2024 2

Actually, I'm surprised that I haven't received this feedback in the 7 years since reviewdog was created. Perhaps most users are happy with the comments from 🐶. The comments are designed to be minimally intrusive, without introducing any new lines and with a small font size to avoid being overly distracting.

I'm not strictly opposed to changing this, but I don't want to make any hasty decisions without careful consideration.

For example, by searching "reported by reviewdog", you can find extensive use of reviewdog in OSS projects. This data could be potentially valuable. While there are currently no tools for analyzing this data, it is conceivable that such tools could be developed to leverage this information effectively.

from reviewdog.

mgaitan avatar mgaitan commented on June 6, 2024 2

Maybe it is an idea to have it on by default and give to option to remove it from configuration?

that exactly is my proposal

from reviewdog.

nogweii avatar nogweii commented on June 6, 2024 1

It would be more complicated, but could it instead mention the "reported by reviewdog" on only the first review comment? So it's still there, at least once in each MR, but isn't overly redundant by being in every single message.

from reviewdog.

Okabe-Junya avatar Okabe-Junya commented on June 6, 2024

Hello folks!!

For team, Thank you for the wonderful software !!
For mgaitan, great suggestion!!

I also agree with this proposal. Although I like seeing dogs, having every comment include "reported by reviewdog 🐶" might be a bit too much.

I have created a PR #1667 to fix this issue. PTAL :)

from reviewdog.

mgaitan avatar mgaitan commented on June 6, 2024

@haya14busa in order to find the use "reviewdog in OSS projects" at least in github actions you can find directly in the workflows

https://github.com/search?q=reviewdog++path%3A.github%2Fworkflows%2F+language%3AYAML&type=Code&ref=advsearch&l=YAML&l=

I know it's a not a big deal, but this would be more precise as it avoids to compute potential comments like "why this was not reported by reviewdog? Oh, we are not using it yet!"

from reviewdog.

haya14busa avatar haya14busa commented on June 6, 2024

Comments with "reported by reviewdog" are not only useful for finding reviewdog usage, but also useful for analysing integrated tools data.

from reviewdog.

tvbeek avatar tvbeek commented on June 6, 2024

To be honest I prefer to have it there. It is useful to see what tool reports a message.

I use it on GitLab and have a special user that place this report but is used for multiple tools. That means that the message makes clear what reports the message.

Maybe it is an idea to have it on by default and give to option to remove it from configuration?

from reviewdog.

tvbeek avatar tvbeek commented on June 6, 2024

Maybe it is an idea to have it on by default and give to option to remove it from configuration?

that exactly is my proposal

Yes, sorry I did read the issue, found it a good idea and then did read the linked PR where it is totally removed. That is where I mixed the 2 options. And wanted to explain why it is useful to have it visible (at least for me).

Your proposal sounds good for me 👍

from reviewdog.

Okabe-Junya avatar Okabe-Junya commented on June 6, 2024

I think flags or configs are a very good idea too :)

However, if it becomes possible to freely configure, wouldn't searches for comments with "reported by reviewdog" lose their value? (We would no longer be able to search through all OSS using reviewdog.)

Meaning, we will search projects through the .github/workflows files like thie.

https://github.com/search?q=reviewdog++path%3A.github%2Fworkflows%2F+language%3AYAML&type=Code&ref=advsearch&l=YAML&l=

from reviewdog.

tvbeek avatar tvbeek commented on June 6, 2024

I think flags or configs are a very good idea too :)

However, if it becomes possible to freely configure, wouldn't searches for comments with "reported by reviewdog" lose their value? (We would no longer be able to search through all OSS using reviewdog.)

Meaning, we will search projects through the .github/workflows files like thie.

https://github.com/search?q=reviewdog++path%3A.github%2Fworkflows%2F+language%3AYAML&type=Code&ref=advsearch&l=YAML&l=

But that is only on GitHub not on other providers. And with a default I suspect that you will find between 90% and 99% of the projects that use it.

from reviewdog.

Okabe-Junya avatar Okabe-Junya commented on June 6, 2024

you will find between 90% and 99% of the projects that use it.

Of course, many projects can be found. However, if it's not 100%, there are more reliable methods of searching (although I'm not familiar with GitLab or other providers).

Meaning, if we adopt the idea of configuring with configs or flags (which I also agree), I will no longer use "reported by reviewdog" for data analysis or searching OSS like this

Comments with "reported by reviewdog" are not only useful for finding reviewdog usage but also useful for analyzing integrated tools data.

from reviewdog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.