Default button behaviour does not work as expected.

[revivius]

Default button behaviour does not work as expected.

[Revivius]

@Saljack both works for me. Can you verify the issue please ?

[dylanvorster]

Steps to reproduce on Mac:

• Go to class
• Click somewhere in class file, must be directly inside class, not in a method call/constructor
• CTRL + i (insert code)
• Select override and Implement method / Insert Getters and Setters
• Select something press enter
• Nothing happens.

Its worth noting that in the screenshot by @Saljack clearly has a focus set on the 'Find' button while my screenshot does not but also doesn't work, even though the Ok button is clearly supposed to be selected.

[Saljack]

If I use Windows LAF everything works ok. So my scenario is:

1. Press Alt + Insert (Insert code)
2. Select Getter and Setter
3. Select some field with space
4. Press Enter
5. Nothing happen (expected insert generated setter and getter methods)

There are screenshot from insert dialog:

[markiewb]

So the default-button behavior does not work using this LAF.

@Revivius: Can you please rename this issue accordingly

Producible for me
Product Version: NetBeans IDE 8.1 (Build 201510222201)
Java: 1.8.0_71; Java HotSpot(TM) 64-Bit Server VM 25.71-b15
Runtime: Java(TM) SE Runtime Environment 1.8.0_71-b15
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)

[markiewb]

@Revivius: https://tips4java.wordpress.com/2008/10/25/enter-key-and-button/

[markiewb]

@Revivius: Also have a look at the sources of https://github.com/JetBrains/intellij-community/tree/master/platform/platform-impl/src/com/intellij/ide/ui/laf Perhaps the guys at JB fixed such an issue?

[Revivius]

@markiewb setting "Button.defaultButtonFollowsFocus" to TRUE did not help, may be related to:

https://netbeans.org/bugzilla/show_bug.cgi?id=149102

This is the last issue I want to address in v1.4.

[markiewb]

@Revivius: Yes. I also tried it out and it did not work. Perhaps the LAF alters the "inputMap"/"actionInputMap" of JPanels/JTrees?

JTrees, because in all the screenshot there are trees, which do not delegate the ENTER-key.

[Revivius]

@markiewb I tried to use BasicTreeUI and MetalTreeUI instead of DarculaTreeUI but no change. I cant see anything that modifies input map of JTrees also. Here it is:

https://github.com/bulenkov/Darcula/blob/master/src/com/bulenkov/darcula/DarculaLaf.java#L354-L358

[Revivius]

@Saljack thank you for reporting and @dylanvorster for clarifying.

and @markiewb thank you once more for pointing me to right direction. With this fixed I think we are ready for v1.4.

[markiewb]

@Revivius:

f9ece35#diff-9fbfce4e959f187cc27903ee921c1824L441

Why did you remove the invertIcon-feature from #41 ? Accidentally? maybeEnableIconFilter was introduced, but never used - at least in that commit!

[Revivius]

@markiewb it was an accidentall commit and i have corrected it. Last commit uses maybeEnableIconFilter.

[markiewb]

@Revivius: Ok, yes you are correct. I found it aa46792#diff-9fbfce4e959f187cc27903ee921c1824R446

[markiewb]

Cool. It really works. Tested with toString/getter/setter code generator.

[Revivius]

Good to know!