Notification "links" are too hard to read

[revivius]

Notification "links" are too hard to read

[phansson]

Someone has already logged this as an RFE on NetBeans: https://netbeans.org/bugzilla/show_bug.cgi?id=246199.

As far as I can tell the problem will solve itself - also in nb-dracula - when this code change is released.

[Revivius]

@phansson you are right; core.ui in NB 8.1 still has the hardcoded BLUE color and changing the "u" and "a" style colors as described in nbdev mailing list does not solve the problem, so we will have to wait until fix is released. Though I have problem understanding the dates in the NetBeans Bugzilla. Fix seems to be merged at 2015-09-13 into main-silver and NetBeans NB 8.1 was released in 2015-11-04 according to NetBeans release history, so I think it should already have been there. What am I missing ?

[Revivius]

@phansson please vote for this issue for other hardcoded colors:

https://netbeans.org/bugzilla/show_bug.cgi?id=257675

Thank you!

[markiewb]

@Revivius: Ask [email protected] (the dev, who applied the change)! Perhaps the version of the modules hasn't be changed and thus an old module has been included in NB8.1

I filed https://netbeans.org/bugzilla/show_bug.cgi?id=257823 and will ask Jirka for a change. Perhaps it can be still included in the upcoming 8.1patch1?!

[Revivius]

@markiewb voted!

Do you think https://netbeans.org/bugzilla/show_bug.cgi?id=257675 will make it to 8.1patch1 ? Or it is too late for the patch?

[markiewb]

@Revivius: I wrote an email to Jirka regarding #257823. Lets wait for the answer

Regarding: https://netbeans.org/bugzilla/show_bug.cgi?id=257675 I doubt it. Provide a patch for the issue and then contact Geertjan Wielenga (the enthusiastic NB product manager, who wrote already two blog entries about the plugin). Perhaps then it can be included in Patch2 or later

[markiewb]

@Revivius: BTW there are still 3 good pull requests to be merged!

[neilcsmith-net]

@markiewb as just commented on the mailing list, check the original patch from that issue vs what was actually committed. The patch might have fixed the issue, what was committed wouldn't. The "fix" is probably already in there! 😄

[Revivius]

@neilcsmith-net, @markiewb there are two NotificationImpl classes. Please see my post on dev mailing list:

http://forums.netbeans.org/viewtopic.php?p=168760#168760

[markiewb]

Fixed in NB8.2
https://netbeans.org/bugzilla/show_bug.cgi?id=257675#c5
https://netbeans.org/bugzilla/show_bug.cgi?id=246199#c8

[Revivius]

@markiewb; thank you for fixing

https://netbeans.org/bugzilla/show_bug.cgi?id=257675#c5

I checked your fixes in NB 8.2 and they are all great except:

[Revivius]

Fixed by @markiewb in NetBeans 8.2:

https://netbeans.org/bugzilla/show_bug.cgi?id=246199#c8

Thank you @markiewb for making NB look better in dark LAFs.

[markiewb]

@Revivius:

I checked your fixes in NB 8.2 and they are all great except:

Filed https://netbeans.org/bugzilla/show_bug.cgi?id=268544 and fixed in the dev version.