issues parsing invalid declarations inside phantomjs

[reworkcss]

issues parsing invalid declarations inside phantomjs

[conradz]

This seems to have been fixed in the latest version of css. Please re-open if it still occurs in the latest version 2.2.1. If you're running an older version you can expect that there will be bugs that have been fixed.

[pocketjoso]

@conradz Did you actually test that it works inside phantomjs with [email protected]? As I mentioned I had issues using that version inside phantomjs last time I tried, but will try again now.

[pocketjoso]

So @conradz I tested this myself now in [email protected] (I had to manually revert this commit, as it doesn't work in phantomjs) - and it doesn't work in this version either, in phantomjs.

with this test css:
.breakingDeclaration{filter:unquote("()")}html{color:red;}div{color:blue;}

outside phantomjs -- correct

css.parse outside of phantomjs produces an ast with rules.length 3:

.breakingDeclaration
property: filter
value: unquote("()")

html
property: color
value: red

div
property: color
value: blue

inside phantomjs -- incorrect

whereas inside phantomjseverything gets incorrectly collapsed into the broken declaration, ast rules.length 1:

.breakingDeclaration
property: filter
value: unquote("()")}html{color:red;}div{color:blue

---

Like I said from the beginning, I'm not sure if there's anything you can do about this form your libraries point of view. Just wanted to clarify that is doesn't get fixed by latest version.

Cheers

[pocketjoso]

I just don't have enough understanding of what css.parse does that could yield a different result when run inside phantomjs. I might just rewrite my usage so I do the parsing outside of phantomjs, seralise the ast, and then pass it in.

[conradz]

OK, thanks for the clarification, I hadn't understood that it was specific to phantomjs. Yeah I would think that the best way would be to parse in Node, transferring the CSS source to Node instead of parsing in phantomjs. Most likely an issue with regex matching in phantomjs, although I couldn't guarantee that is the problem.