Giter Site home page Giter Site logo

Comments (4)

rfoltyns avatar rfoltyns commented on May 26, 2024

I'll clean it up in 1.3.3, cause it's not the only thread that may start in -core (see buffer pool).

Theoretically, only the ElasticsearchAppender implements org.apache.logging.log4j.core.Lifecycle or org.apache.logging.log4j.core.Lifecycle2 - I don't remember which one was called during reconfigure.
I started to integrate with Log4j2 Lifecycle, but it's not complete yet - just a couple of classes tbh. See f6e83164
Target picuture is:

  • all necessary -core classes with org.appenders.log4j2.elasticsearch.LifeCycle (to start decoupling from Log4j2)
  • ElasticsearchAppender with Log4j2 Lifecycle calling the above (BatchDelivery, BulkEmitter, clients, pools, etc.)

from log4j2-elasticsearch.

JeromeSoussens avatar JeromeSoussens commented on May 26, 2024

Hi,

Thanks for the feedback.
So I close this issue and I will test 1.3.3 :)

from log4j2-elasticsearch.

foltyr01 avatar foltyr01 commented on May 26, 2024

@JeromeSoussens Thanks for this! I had it in mind for a long time.
I just released a fix for this in 1.3.3.
Enjoy! :)

from log4j2-elasticsearch.

JeromeSoussens avatar JeromeSoussens commented on May 26, 2024

Hi @foltyr01 ,
Thanks for that ! 👍
I'll try it soon.

from log4j2-elasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.