Support Opt-In behaviour for logging requests

[bradykieffer]

Support Opt-In behaviour for logging requests

[tclancy]

That would work, it just wouldn't suit our use case.

I just realized that the silent flag hasn't yet been published, is that something that's going to happen soon by any chance?

Argh, I will try to do that as soon as I can; I've just switched to a new laptop so it won't be until next week, but if you don't see it by Friday, please ping me here.

[tclancy]

I haven't forgotten about this, just a crazy week.

[tclancy]

That definitely makes sense, we have a few endpoints we aren't particularly interested in or are only interested in if they error, so maybe instead of a hard true/ false the decorator could accept a condition or lambda just to make this even more fun for you to implement?

I can certainly see users who only want to use the package in certain cases but for backwards-compatibility the default would still need to be everything, yeah.

[bradykieffer]

@tclancy what about instead of a true false in the setting we made it an enum / well formed string, something like:

REQUEST_LOGGING_DEFAULT_OPT_IN_LEVEL: str = "ALL" # Default value, opt in to logging all requests

Where it could also be something like ERRORS, NONE, etc. I don't suspect that will break anything.

EDIT: (as a side note, I'm not opposed to implementing a lambda, I'm just wondering what could be the easiest thing to use / what level of sophistication would be needed from the get go)

Also as a side note, I just realized that the silent flag hasn't yet been published, is that something that's going to happen soon by any chance?

[bradykieffer]

May as well get it to suit your use case + mine so it's more immediately useful 😄

[bradykieffer]

@tclancy I also haven't forgotten, I just put up a PR for this: #103