Problem logging URI

[mathj30]

Problem logging URI

[tclancy]

A request doesn't have an associated status code, only a response.

[mathj30]

I know a request does not have a status code. So there is no method to log the URI on the response with an error?

[tclancy]

I'm not clear what you're asking. In process_response, it appears to log the URI (in the resp_log value) unless I am misreading it:

def process_response(self, request, response):
        resp_log = "{} {} - {}".format(request.method, request.get_full_path(), response.status_code)
        logging_context = self._get_logging_context(request, response)

        if response.status_code in range(400, 600):
            self.logger.log_error(logging.INFO, resp_log, logging_context)
            self._log_resp(logging.ERROR, response, logging_context)
        else:
            self.logger.log(logging.INFO, resp_log, logging_context)
            self._log_resp(self.log_level, response, logging_context)

        return response

[mathj30]

Ho I see... But only at the info level.. If we activate the info level we now have all the requests. Shouldn't those line be more in the range of:

`
def process_response(self, request, response):
resp_log = "{} {} - {}".format(request.method, request.get_full_path(), response.status_code)
logging_context = self._get_logging_context(request, response)

    if response.status_code in range(400, 600):
        self.logger.log_error(**logging.ERROR**, resp_log, logging_context)
        self._log_resp(logging.ERROR, response, logging_context)
    else:
        self.logger.log(logging.INFO, resp_log, logging_context)
        self._log_resp(self.log_level, response, logging_context)

    return response

`

[tclancy]

That makes sense to me as a behavior but perhaps it should be configurable? Happy to accept a PR either way.

[mathj30]

Not sure how it make sense.. In the event of a crash you don't know the URI that was called unless you log all request made.