Issues observing more than one property

[allforabit]

Issues observing more than one property

[ricardomatias]

My bad, I put the updated one inside the LiveAPI folder by mistake. Well spotted @allforabit!

[allforabit]

It's to do with the event callback name not being entirely unique. I've got a workaround by changing the callback signature in live api:

callback(objectPath, objectId, property)

and I generate a unique name with this function and use in place of just the objectPath:

function callbackName(path, id) {
	if(id) {
		return path + '-' + id;
	}
	return path;
}

[allforabit]

I have a PR there if you want to try it out

[ricardomatias]

Thanks for the thorough description of the problem and testable scenario!

[allforabit]

Thanks very much for doing the update! I still seem to be having the same issue though after updating and using the latest device though I'm wondering if there was an issue updating it? Thanks again :-)

[allforabit]

That's great, thanks for that. I did notice one other issue, there's always one :-) The removeObserver function isn't using the proper callback name in all places. Here's the updated function that seems to do the trick:

function removeObserver(args) {
	const res = JSON.parse(args);

	// * Request UUID
	var uuid = res.uuid;
	var objectId = res.objectId;
	var eventId = res.args.eventId;
	var objectPath = res.args.objectPath;

	var cbName = callbackName(objectPath, objectId)

	if (callbackEvents[cbName] !== undefined) {
		var listeners = callbackEvents[cbName].listeners;
		var idx = listeners.indexOf(eventId);

		listeners.splice(idx, 1);

		if (!listeners.length) {
			const api = callbackEvents[cbName].api;
			api.id = 0;
			delete callbackEvents[cbName];
		}
	}

	onSuccess(uuid);
}